Make sure tcx.create_def also depends on the forever red node, instead of just tcx.at(span).create_def by oli-obk · Pull Request #121084 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
oversight from #119136
Not actually an issue, because all uses of tcx.create_def were in the resolver, which is eval_always, but still good to harden against future uses of create_def
cc @petrochenkov @WaffleLapkin
…ead of just tcx.at(span).create_def
r? @lcnr
rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit 2e900ed has been approved by WaffleLapkin
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…=WaffleLapkin
Make sure tcx.create_def also depends on the forever red node, instead of just tcx.at(span).create_def
oversight from rust-lang#119136
Not actually an issue, because all uses of tcx.create_def were in the resolver, which is eval_always, but still good to harden against future uses of create_def
cc @petrochenkov @WaffleLapkin
| // needs to be re-evaluated. |
|---|
| self.dep_graph.read_index(DepNodeIndex::FOREVER_RED_NODE); |
| // The following call has the side effect of modifying the tables inside `definitions`. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment looks related to the moved code, and also outdated.
It should probably be updated and maybe also moved.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 😆 I already had the commit ready
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 6 pull requests
Successful merges:
- rust-lang#120893 (Move some tests)
- rust-lang#120966 (Remove importing suggestions when there is a shadowed typo candidate)
- rust-lang#121035 (Format
asynctrait bounds in rustfmt) - rust-lang#121075 (Fix false positive with if let and ranges)
- rust-lang#121083 (Extend documentation for
Ty::to_opt_closure_kindmethod) - rust-lang#121084 (Make sure
tcx.create_defalso depends on the forever red node, instead of justtcx.at(span).create_def)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#121084 - oli-obk:create_def_forever_red2, r=WaffleLapkin
Make sure tcx.create_def also depends on the forever red node, instead of just tcx.at(span).create_def
oversight from rust-lang#119136
Not actually an issue, because all uses of tcx.create_def were in the resolver, which is eval_always, but still good to harden against future uses of create_def
cc @petrochenkov @WaffleLapkin
Was merged in #121086 (at least first commit)
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 55f9aed has been approved by WaffleLapkin
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#111106 (Add known issue of let binding to format_args doc)
- rust-lang#118749 (Make contributing to windows bindings easier)
- rust-lang#120982 (Add APIs for fetching foreign items )
- rust-lang#121022 (rustdoc: cross-crate re-exports: correctly render late-bound params in source order even if early-bound params are present)
- rust-lang#121082 (Clarified docs on non-atomic oprations on owned/mut refs to atomics)
- rust-lang#121084 (Make sure
tcx.create_defalso depends on the forever red node, instead of justtcx.at(span).create_def) - rust-lang#121098 (Remove unnecessary else block from
thread_local!expanded code) - rust-lang#121105 (Do not report overflow errors on ConstArgHasType goals)
- rust-lang#121116 (Reinstate some delayed bugs.)
- rust-lang#121122 (Enforce coroutine-closure layouts are identical)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#121084 - oli-obk:create_def_forever_red2, r=WaffleLapkin
Make sure tcx.create_def also depends on the forever red node, instead of just tcx.at(span).create_def
oversight from rust-lang#119136
Not actually an issue, because all uses of tcx.create_def were in the resolver, which is eval_always, but still good to harden against future uses of create_def
cc @petrochenkov @WaffleLapkin
bors added a commit to rust-lang-ci/rust that referenced this pull request
Remove feed_local_def_id
best reviewed commit by commit
Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches
based on rust-lang#121084
r? @petrochenkov
bors added a commit to rust-lang-ci/rust that referenced this pull request
Remove feed_local_def_id
best reviewed commit by commit
Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches
based on rust-lang#121084
r? @petrochenkov
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…enkov
Remove feed_local_def_id
best reviewed commit by commit
Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches
based on rust-lang#121084
r? @petrochenkov
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…enkov
Remove feed_local_def_id
best reviewed commit by commit
Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches
based on rust-lang#121084
r? @petrochenkov
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…enkov
Remove feed_local_def_id
best reviewed commit by commit
Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches
based on rust-lang#121084
r? @petrochenkov
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…enkov
Remove feed_local_def_id
best reviewed commit by commit
Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches
based on rust-lang#121084
r? @petrochenkov
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#121089 - oli-obk:create_def_feed, r=petrochenkov
Remove feed_local_def_id
best reviewed commit by commit
Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches
based on rust-lang#121084
r? @petrochenkov
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.