Ignore unsized types when trying to determine the size of the original type by Urgau · Pull Request #121104 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care about the opposite case, where we're casting an unsized type to a sized type? Otherwise, r=me
✌️ @Urgau, you can now approve this pull request!
If @compiler-errors told you to "r=me" after making some further change, please make that change, then do @bors r=@compiler-errors
Do we care about the opposite case, where we're casting an unsized type to a sized type? Otherwise, r=me
I don't think so. It can never be reached, a size of 0 has nothing smaller than him.
📌 Commit ddec8c5 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#120449 (Document requirements for unsized {Rc,Arc}::from_raw)
- rust-lang#120505 (Fix BTreeMap's Cursor::remove_{next,prev})
- rust-lang#120672 (std::thread update freebsd stack guard handling.)
- rust-lang#121088 (Implicitly enable evex512 if avx512 is enabled)
- rust-lang#121104 (Ignore unsized types when trying to determine the size of the original type)
- rust-lang#121107 (Fix msg for verbose suggestions with confusable capitalization)
- rust-lang#121113 (Continue compilation even if inherent impl checks fail)
- rust-lang#121120 (Add
ErrorGuaranteedtoast::LitKind::Err,token::LitKind::Err.)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.