Add more checks for unnamed_fields during HIR analysis by clubby789 · Pull Request #121198 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #121151
I also found that we don't prevent enums here so
#[repr(C)] #[derive(Debug)] enum A { #[default] B, C, }
#[repr(C)] #[derive(Debug)] struct D { _: A, }
leads to an ICE on an self.is_struct() || self.is_union() assertion, so fixed that too.
r? @estebank
rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Add more checks for Add more checks for unnamed_field during HIR analysisunnamed_fields during HIR analysis
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! thanks
r? compiler-errors @bors r+ rollup
📌 Commit c370403 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…s, r=compiler-errors
Add more checks for unnamed_fields during HIR analysis
Fixes rust-lang#121151
I also found that we don't prevent enums here so
#[repr(C)]
#[derive(Debug)]
enum A {
#[default]
B,
C,
}
#[repr(C)]
#[derive(Debug)]
struct D {
_: A,
}leads to an ICE on an self.is_struct() || self.is_union() assertion, so fixed that too.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
📌 Commit 62b789f has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…s, r=compiler-errors
Add more checks for unnamed_fields during HIR analysis
Fixes rust-lang#121151
I also found that we don't prevent enums here so
#[repr(C)]
#[derive(Debug)]
enum A {
#[default]
B,
C,
}
#[repr(C)]
#[derive(Debug)]
struct D {
_: A,
}leads to an ICE on an self.is_struct() || self.is_union() assertion, so fixed that too.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#118264 (Optimize
VecDeque::drainfor (half-)open ranges) - rust-lang#121079 (distribute tool documentations and avoid file conflicts on
x install) - rust-lang#121100 (Detect when method call on argument could be removed to fulfill failed trait bound)
- rust-lang#121160 (rustdoc: fix and refactor HTML rendering a bit)
- rust-lang#121198 (Add more checks for
unnamed_fieldsduring HIR analysis) - rust-lang#121221 (AstConv: Refactor lowering of associated item bindings a bit)
- rust-lang#121237 (Use better heuristic for printing Cargo specific diagnostics)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#120526 (rustdoc: Correctly handle long crate names on mobile)
- rust-lang#121100 (Detect when method call on argument could be removed to fulfill failed trait bound)
- rust-lang#121160 (rustdoc: fix and refactor HTML rendering a bit)
- rust-lang#121198 (Add more checks for
unnamed_fieldsduring HIR analysis) - rust-lang#121218 (Fix missing trait impls for type in rustc docs)
- rust-lang#121221 (AstConv: Refactor lowering of associated item bindings a bit)
- rust-lang#121237 (Use better heuristic for printing Cargo specific diagnostics)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#121198 - clubby789:unnamed-fields-hir-checks, r=compiler-errors
Add more checks for unnamed_fields during HIR analysis
Fixes rust-lang#121151
I also found that we don't prevent enums here so
#[repr(C)]
#[derive(Debug)]
enum A {
#[default]
B,
C,
}
#[repr(C)]
#[derive(Debug)]
struct D {
_: A,
}leads to an ICE on an self.is_struct() || self.is_union() assertion, so fixed that too.
that may beclosed by this pull request
Labels
`#![feature(unnamed_fields)]`
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.