Doc: Fix incorrect reference to integer in Atomic{Ptr,Bool}::as_ptr. by Lee-Janggun · Pull Request #121977 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I am assuming "resulting integer" is an error, since we are talking about pointers and booleans here. Seems like it was missed while copy & pasting the docs from the integer versions. I also checked the rest of the docs, and this was the only mention of integers.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @workingjubilee (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 4, 2024

Lee-Janggun changed the title~~Fix incorrect reference to integer in Atomic{Ptr,Bool}::as_ptr.~~ Doc: Fix incorrect reference to integer in Atomic{Ptr,Bool}::as_ptr.

Mar 4, 2024

📌 Commit 05e68fa has been approved by WaffleLapkin

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 4, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Mar 4, 2024

Doc: Fix incorrect reference to integer in Atomic{Ptr,Bool}::as_ptr.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2024

…llaumeGomez

Rollup of 9 pull requests

Successful merges:

rust-lang#120976 (constify a couple thread_local statics)
rust-lang#121576 (Convert the rest of the visitors to use VisitorResult)
rust-lang#121826 (Use root obligation on E0277 for some cases)
rust-lang#121928 (Extract an arguments struct for Builder::then_else_break)
rust-lang#121958 (Fix redundant import errors for preload extern crate)
rust-lang#121959 (Removing absolute path in proc-macro)
rust-lang#121968 (Don't run test_get_os_named_thread on win7)
rust-lang#121977 (Doc: Fix incorrect reference to integer in Atomic{Ptr,Bool}::as_ptr.)
rust-lang#121978 (Fix duplicated path in the "not found dylib" error)