pattern analysis: abort on arity mismatch by Nadrieril · Pull Request #121987 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
As this can cause panics on array accesses later.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit 2af01a2 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Thanks!
@bors rollup=always
jhpratt added a commit to jhpratt/rust that referenced this pull request
… r=compiler-errors
pattern analysis: abort on arity mismatch
This is one more PR replacing panics by Err() aborts. I recently audited all the unwrap() calls, but I had forgotten about array accesses. (Again discovered by rust-analyzer).
r? @compiler-errors
bors added a commit to rust-lang-ci/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
… r=compiler-errors
pattern analysis: abort on arity mismatch
This is one more PR replacing panics by Err() aborts. I recently audited all the unwrap() calls, but I had forgotten about array accesses. (Again discovered by rust-analyzer).
r? @compiler-errors
This was referenced
Mar 5, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#121213 (Add an example to demonstrate how Rc::into_inner works)
- rust-lang#121262 (Add vector time complexity)
- rust-lang#121287 (Clarify/add
must_usemessage for Rc/Arc/Weak::into_raw.) - rust-lang#121664 (Adjust error
yield/awaitlowering) - rust-lang#121826 (Use root obligation on E0277 for some cases)
- rust-lang#121838 (Use the correct logic for nested impl trait in assoc types)
- rust-lang#121913 (Don't panic when waiting on poisoned queries)
- rust-lang#121987 (pattern analysis: abort on arity mismatch)
- rust-lang#121993 (Avoid using unnecessary queries when printing the query stack in panics)
- rust-lang#121997 (interpret/cast: make more matches on FloatTy properly exhaustive)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#121987 - Nadrieril:abort-on-arity-mismatch, r=compiler-errors
pattern analysis: abort on arity mismatch
This is one more PR replacing panics by Err() aborts. I recently audited all the unwrap() calls, but I had forgotten about array accesses. (Again discovered by rust-analyzer).
r? @compiler-errors
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.