Promote riscv64gc-unknown-linux-musl to tier 2 by Amanieu · Pull Request #122049 · rust-lang/rust (original) (raw)

@Amanieu

@rustbot

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-infra

Relevant to the infrastructure team, which will review and decide on the PR/issue.

labels

Mar 5, 2024

@Amanieu

I'm looking for a second target maintainer, this is required for tier 2 support.

cc @kraj @nmeum since you were involved in #82202

@kraj

I'm looking for a second target maintainer, this is required for tier 2 support.

cc @kraj @nmeum since you were involved in #82202

@Amanieu I will be happy to help. Please add me.

kraj

kraj approved these changes Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Amanieu

@Amanieu Amanieu changed the titlePromote riscv64gc-unknown-linux-gnu to tier 2 Promote riscv64gc-unknown-linux-musl to tier 2

Mar 6, 2024

@Mark-Simulacrum

This should probably update the platform support docs to indicate the tier 2 target.

@bors

@kraj

@Dylan-DPC Dylan-DPC added S-waiting-on-MCP

Status: PR has a compiler MCP and is waiting for the compiler MCP to complete.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 1, 2024

@Amanieu Amanieu marked this pull request as ready for review

June 22, 2024 15:05

@rustbot

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

These commits modify compiler targets.
(See the Target Tier Policy.)

@Amanieu Amanieu added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-MCP

Status: PR has a compiler MCP and is waiting for the compiler MCP to complete.

labels

Jul 3, 2024

@Mark-Simulacrum

@bors

📌 Commit 7478987 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 4, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 4, 2024

@bors

…imulacrum

Promote riscv64gc-unknown-linux-musl to tier 2

@bors

@rust-log-analyzer

This comment has been minimized.

@bors bors added the S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

label

Aug 3, 2024

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 5, 2024

@bors

…imulacrum

Promote riscv64gc-unknown-linux-musl to tier 2

@bors

@bors bors added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Aug 5, 2024

@rust-log-analyzer

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@tgross35

@bors retry

Looks like some kind of networking error

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 5, 2024

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 5, 2024

@tgross35

…-Simulacrum

Promote riscv64gc-unknown-linux-musl to tier 2

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 5, 2024

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 5, 2024

@bors

…iaskrgr

Rollup of 5 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 6, 2024

@rust-timer

Rollup merge of rust-lang#122049 - Amanieu:riscv64-musl-tier2, r=Mark-Simulacrum

Promote riscv64gc-unknown-linux-musl to tier 2

@Mark-Simulacrum Mark-Simulacrum added relnotes

Marks issues that should be documented in the release notes of the next release.

and removed relnotes

Marks issues that should be documented in the release notes of the next release.

labels

Oct 2, 2024

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Oct 18, 2024

@tmeijn

This MR contains the following updates:

Package Update Change
rust minor 1.81.0 -> 1.82.0

MR created with the help of el-capitano/tools/renovate-bot.

Proposed changes to behavior should be submitted there as MRs.

Release Notes

rust-lang/rust (rust)

v1.82.0

Compare Source

==========================

Language

Compiler

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

This MR has been generated by Renovate Bot.

kxxt added a commit to kxxt/archriscv-packages that referenced this pull request

Oct 20, 2024

@kxxt

Musl Patch

riscv64gc-unknown-linux-musl gets promoted to tier 2 and crt_static_default is updated to false in rust-lang/rust#122049, which triggers rust-lang/rust#82521 (comment) when building stage2 library artifacts (riscv64gc-unknown-linux-gnu -> riscv64gc-unknown-linux-musl).

I patched it to re-enable crt_static_default for riscv64gc-unknown-linux-musl to fix the build and align with the behavior on x86 Arch Linux, where rust-musl defaults to statically link musl.

Wasm compiler_builtins bug

Wasm compiler_builtins rlib from built rust-wasm package includes objects for host architecture(riscv64 in our case, and x86_64 for x86 Arch Linux). This is not reproducible for toolchains installed via rustup so I have reported it to Arch Linux: https://gitlab.archlinux.org/archlinux/packaging/packages/rust/-/issues/3

Complications when building 1.82.0

rust-lang/rust#125016 landed in 1.82.0, which breaks building rust 1.82.0 using our packaged rust 1.81.0. Compiling the new compiler_builtins component requires a rustc compiler that includes rust-lang/rust@99e6a28 but unfortunately 1.81.0 does not, leading to the following ICE: https://archriscv.felixc.at/.status/log.htm?url=logs/rust/rust-1:1.82.0-1.log

internal compiler error: compiler/rustc_codegen_llvm/src/abi.rs:126:22: unsupported float: Reg { kind: Float, size: Size(2 bytes) }

This is mitigated upstream by bumping stage0 to 1.82: rust-lang/rust#129268 (comment)

So we need to first build 1.82.0 rustc once without the f16/f128 handling part in compiler_builtins, to get a compiler that is capable of handling f16/f128. And then we can use this compiler to compile compiler_builtins with f16/f128 handling. It's not easy to do so in one patch. The most easy way is to build and package rust 1.82.0 twice. This PR covers the first part and disable-f16-f128.diff will be removed in the second part.

kxxt added a commit to kxxt/archriscv-packages that referenced this pull request

Oct 20, 2024

@kxxt

Musl Patch

riscv64gc-unknown-linux-musl gets promoted to tier 2 and crt_static_default is updated to false in rust-lang/rust#122049, which triggers rust-lang/rust#82521 (comment) when building stage2 library artifacts (riscv64gc-unknown-linux-gnu -> riscv64gc-unknown-linux-musl).

I patched it to re-enable crt_static_default for riscv64gc-unknown-linux-musl to fix the build and align with the behavior on x86 Arch Linux, where rust-musl defaults to statically link musl.

Wasm compiler_builtins bug

Wasm compiler_builtins rlib from built rust-wasm package includes objects for host architecture(riscv64 in our case, and x86_64 for x86 Arch Linux). This is not reproducible for toolchains installed via rustup so I have reported it to Arch Linux: https://gitlab.archlinux.org/archlinux/packaging/packages/rust/-/issues/3

Complications when building 1.82.0

rust-lang/rust#125016 landed in 1.82.0, which breaks building rust 1.82.0 using our packaged rust 1.81.0. Compiling the new compiler_builtins component requires a rustc compiler that includes rust-lang/rust@99e6a28 but unfortunately 1.81.0 does not, leading to the following ICE: https://archriscv.felixc.at/.status/log.htm?url=logs/rust/rust-1:1.82.0-1.log

internal compiler error: compiler/rustc_codegen_llvm/src/abi.rs:126:22: unsupported float: Reg { kind: Float, size: Size(2 bytes) }

This is mitigated upstream by bumping stage0 to 1.82: rust-lang/rust#129268 (comment)

So we need to first build 1.82.0 rustc once without the f16/f128 handling part in compiler_builtins, to get a compiler that is capable of handling f16/f128. And then we can use this compiler to compile compiler_builtins with f16/f128 handling. It's not easy to do so in one patch. The most easy way is to build and package rust 1.82.0 twice. This PR covers the first part and disable-f16-f128.diff will be removed in the second part.

@kxxt kxxt mentioned this pull request

Oct 20, 2024

felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request

Oct 20, 2024

@kxxt @felixonmars

Musl Patch

riscv64gc-unknown-linux-musl gets promoted to tier 2 and crt_static_default is updated to false in rust-lang/rust#122049, which triggers rust-lang/rust#82521 (comment) when building stage2 library artifacts (riscv64gc-unknown-linux-gnu -> riscv64gc-unknown-linux-musl).

I patched it to re-enable crt_static_default for riscv64gc-unknown-linux-musl to fix the build and align with the behavior on x86 Arch Linux, where rust-musl defaults to statically link musl.

Wasm compiler_builtins bug

Wasm compiler_builtins rlib from built rust-wasm package includes objects for host architecture(riscv64 in our case, and x86_64 for x86 Arch Linux). This is not reproducible for toolchains installed via rustup so I have reported it to Arch Linux: https://gitlab.archlinux.org/archlinux/packaging/packages/rust/-/issues/3

Complications when building 1.82.0

rust-lang/rust#125016 landed in 1.82.0, which breaks building rust 1.82.0 using our packaged rust 1.81.0. Compiling the new compiler_builtins component requires a rustc compiler that includes rust-lang/rust@99e6a28 but unfortunately 1.81.0 does not, leading to the following ICE: https://archriscv.felixc.at/.status/log.htm?url=logs/rust/rust-1:1.82.0-1.log

internal compiler error: compiler/rustc_codegen_llvm/src/abi.rs:126:22: unsupported float: Reg { kind: Float, size: Size(2 bytes) }

This is mitigated upstream by bumping stage0 to 1.82: rust-lang/rust#129268 (comment)

So we need to first build 1.82.0 rustc once without the f16/f128 handling part in compiler_builtins, to get a compiler that is capable of handling f16/f128. And then we can use this compiler to compile compiler_builtins with f16/f128 handling. It's not easy to do so in one patch. The most easy way is to build and package rust 1.82.0 twice. This PR covers the first part and disable-f16-f128.diff will be removed in the second part.

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Oct 27, 2024

@he32

Pkgsrc changes:

Upstream changes:

Version 1.82.0 (2024-10-17)

Language

Compiler

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

@karalabe

Something seems to be off, because this platform doens't seem to work, even though it's promoted to Tier 2 with Host Tools?

curl -sSf https://sh.rustup.rs | sh -s -- --profile minimal -y

curl: (22) The requested URL returned error: 404
rustup: installer for platform 'riscv64gc-unknown-linux-musl' not found, this may be unsupported

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

Feb 2, 2025

@he32

Pkgsrc changes:

Upstream changes:

Version 1.82.0 (2024-10-17)

Language

Compiler

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.