Remove the unused field_remapping field from TypeLowering by beetrees · Pull Request #122166 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

beetrees

The field_remapping field of TypeLowering has been unused since #121665. This PR removes it, then replaces the TypeLowering struct with its only remaining member &'ll Type.

@rustbot

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 8, 2024

erikdesjardins

@beetrees

davidtwco

@davidtwco

@bors

📌 Commit d673fd8 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 11, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 11, 2024

@matthiaskrgr

…=davidtwco

Remove the unused field_remapping field from TypeLowering

The field_remapping field of TypeLowering has been unused since rust-lang#121665. This PR removes it, then replaces the TypeLowering struct with its only remaining member &'ll Type.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 11, 2024

@bors

…kingjubilee

Rollup of 15 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 11, 2024

@rust-timer

Rollup merge of rust-lang#122166 - beetrees:remove-field-remapping, r=davidtwco

Remove the unused field_remapping field from TypeLowering

The field_remapping field of TypeLowering has been unused since rust-lang#121665. This PR removes it, then replaces the TypeLowering struct with its only remaining member &'ll Type.

@beetrees beetrees deleted the remove-field-remapping branch

March 11, 2024 21:11

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.