Remove the unused field_remapping
field from TypeLowering
by beetrees · Pull Request #122166 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The field_remapping
field of TypeLowering
has been unused since #121665. This PR removes it, then replaces the TypeLowering
struct with its only remaining member &'ll Type
.
r? @davidtwco
rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit d673fd8 has been approved by davidtwco
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…=davidtwco
Remove the unused field_remapping
field from TypeLowering
The field_remapping
field of TypeLowering
has been unused since rust-lang#121665. This PR removes it, then replaces the TypeLowering
struct with its only remaining member &'ll Type
.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 15 pull requests
Successful merges:
- rust-lang#116791 (Allow codegen backends to opt-out of parallel codegen)
- rust-lang#116793 (Allow targets to override default codegen backend)
- rust-lang#117458 (LLVM Bitcode Linker: A self contained linker for nvptx and other targets)
- rust-lang#119385 (Fix type resolution of associated const equality bounds (take 2))
- rust-lang#121438 (std support for wasm32 panic=unwind)
- rust-lang#121893 (Add tests (and a bit of cleanup) for interior mut handling in promotion and const-checking)
- rust-lang#122080 (Clarity improvements to
DropTree
) - rust-lang#122152 (Improve diagnostics for parenthesized type arguments)
- rust-lang#122166 (Remove the unused
field_remapping
field fromTypeLowering
) - rust-lang#122249 (interpret: do not call machine read hooks during validation)
- rust-lang#122299 (Store backtrace for
must_produce_diag
) - rust-lang#122318 (Revision-related tweaks for next-solver tests)
- rust-lang#122320 (Use ptradd for vtable indexing)
- rust-lang#122328 (unix_sigpipe: Replace
inherit
withsig_dfl
in syntax tests) - rust-lang#122330 (bootstrap readme: fix, improve, update)
r? @ghost
@rustbot
modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#122166 - beetrees:remove-field-remapping, r=davidtwco
Remove the unused field_remapping
field from TypeLowering
The field_remapping
field of TypeLowering
has been unused since rust-lang#121665. This PR removes it, then replaces the TypeLowering
struct with its only remaining member &'ll Type
.
beetrees deleted the remove-field-remapping branch
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.