Add NonNull::<[T]>::is_empty. by zachs18 · Pull Request #122800 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
As per #71146 (comment)
I figured this should be fine to be insta-stable (with an FCP), but I can edit if that is not desired.
r? @Amanieu
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
This comment was marked as resolved.
Relevant to the library API team, which will review and decide on the PR/issue.
and removed T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Rather than make this insta-stable, can you add it to the tracking issue for #71146 so it is included in the FCP?
Sure, I can change the stable(...) attributes to unstable(feature = "...", issue = "71146") and add a comment linking this PR on the issue. I don't have permissions to edit the FCP or the "Public API" section of that issue though.
Add Add NonNull::<[T]>::is_empty (as insta-stable).NonNull::<[T]>::is_empty.
📌 Commit 1b95760 has been approved by Amanieu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…Amanieu
Add NonNull::<[T]>::is_empty.
As per rust-lang#71146 (comment)
I figured this should be fine to be insta-stable (with an FCP), but I can edit if that is not desired.
r? @Amanieu
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…Amanieu
Add NonNull::<[T]>::is_empty.
As per rust-lang#71146 (comment)
I figured this should be fine to be insta-stable (with an FCP), but I can edit if that is not desired.
r? @Amanieu
This was referenced
Mar 22, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#122800 - zachs18:nonnull-slice-is_empty, r=Amanieu
Add NonNull::<[T]>::is_empty.
As per rust-lang#71146 (comment)
I figured this should be fine to be insta-stable (with an FCP), but I can edit if that is not desired.
r? @Amanieu
flip1995 pushed a commit to flip1995/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library API team, which will review and decide on the PR/issue.