Fix misc printing issues in emit=stable_mir by celinval · Pull Request #122801 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Trying to continue the work that @ouz-a started here: #118364
Few modifications beyond fixes:
- I made the
pretty_*functions private. - I added a function to print the instance body
- Changed a bunch of signatures to write to the writer directly.
- Added a function to translate the place to its internal representation, so we could use the internal debug implementation.
- Also removed
pretty_ty, replaced by Display implementation of Ty which uses the internal display.
r? @oli-obk
rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gr9, r=me unless you want oli's review, but also any further review comments could also be done as a follow-up
📌 Commit ebacf7a has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…rrors
Fix misc printing issues in emit=stable_mir
Trying to continue the work that @ouz-a started here: rust-lang#118364
Few modifications beyond fixes:
- I made the
pretty_*functions private. - I added a function to print the instance body
- Changed a bunch of signatures to write to the writer directly.
- Added a function to translate the place to its internal representation, so we could use the internal debug implementation.
- Also removed
pretty_ty, replaced by Display implementation of Ty which uses the internal display.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…rrors
Fix misc printing issues in emit=stable_mir
Trying to continue the work that @ouz-a started here: rust-lang#118364
Few modifications beyond fixes:
- I made the
pretty_*functions private. - I added a function to print the instance body
- Changed a bunch of signatures to write to the writer directly.
- Added a function to translate the place to its internal representation, so we could use the internal debug implementation.
- Also removed
pretty_ty, replaced by Display implementation of Ty which uses the internal display.
bors added a commit to rust-lang-ci/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…rrors
Fix misc printing issues in emit=stable_mir
Trying to continue the work that @ouz-a started here: rust-lang#118364
Few modifications beyond fixes:
- I made the
pretty_*functions private. - I added a function to print the instance body
- Changed a bunch of signatures to write to the writer directly.
- Added a function to translate the place to its internal representation, so we could use the internal debug implementation.
- Also removed
pretty_ty, replaced by Display implementation of Ty which uses the internal display.
This was referenced
Mar 21, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking)
- rust-lang#122358 (Don't ICE when encountering bound regions in generator interior type)
- rust-lang#122696 (Add bare metal riscv32 target.)
- rust-lang#122773 (make "expected paren or brace" error translatable)
- rust-lang#122795 (Inherit
RUSTC_BOOTSTRAPwhen testing wasm) - rust-lang#122799 (Replace closures with
_when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir)
- rust-lang#122806 (Make
type_ascribe!not a built-in)
Failed merges:
- rust-lang#122771 (add some comments to hir::ModuleItems)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#122801 - celinval:smir-pretty, r=compiler-errors
Fix misc printing issues in emit=stable_mir
Trying to continue the work that @ouz-a started here: rust-lang#118364
Few modifications beyond fixes:
- I made the
pretty_*functions private. - I added a function to print the instance body
- Changed a bunch of signatures to write to the writer directly.
- Added a function to translate the place to its internal representation, so we could use the internal debug implementation.
- Also removed
pretty_ty, replaced by Display implementation of Ty which uses the internal display.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.