UnixStream: override read_buf by a1phyr · Pull Request #123084 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added O-unix

Operating system: Unix-like

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 26, 2024

Cool, so my understanding of this change is just applying the forwarding we were already doing. Maybe we should get a macro for that, but this is fine for right now.

@bors r+ rollup

📌 Commit bff13e9 has been approved by workingjubilee

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 26, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Mar 26, 2024

…ingjubilee

UnixStream: override read_buf

Split from rust-lang#122441

r? @workingjubilee

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 27, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 27, 2024

Rollup merge of rust-lang#123084 - a1phyr:unixstream_read_buf, r=workingjubilee

UnixStream: override read_buf

Split from rust-lang#122441

r? @workingjubilee

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 4, 2024

…Denton

Improve several Read implementations

• read_to_end and read_to_string for Cursor
• Error on OOM in read_to_string of &[u8] and VecDeque<u8>
• Avoid making the slices contiguous in VecDeque::read_to_string
• read_exact and (unstable) read_buf_exact for Take
• read_buf for UnixStream and &UnixStream (moved to rust-lang#123084)
• read_to_end for ChildStdErr

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 4, 2024

…Denton

Improve several Read implementations

• read_to_end and read_to_string for Cursor
• Error on OOM in read_to_string of &[u8] and VecDeque<u8>
• Avoid making the slices contiguous in VecDeque::read_to_string
• read_exact and (unstable) read_buf_exact for Take
• read_buf for UnixStream and &UnixStream (moved to rust-lang#123084)
• read_to_end for ChildStdErr

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 4, 2024

Rollup merge of rust-lang#122441 - a1phyr:improve_read_impls, r=ChrisDenton

Improve several Read implementations

• read_to_end and read_to_string for Cursor
• Error on OOM in read_to_string of &[u8] and VecDeque<u8>
• Avoid making the slices contiguous in VecDeque::read_to_string
• read_exact and (unstable) read_buf_exact for Take
• read_buf for UnixStream and &UnixStream (moved to rust-lang#123084)
• read_to_end for ChildStdErr

Labels

O-unix

Operating system: Unix-like

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.