Test that opaque types can't have themselves as a hidden type with incompatible lifetimes by oli-obk · Pull Request #123782 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

fixes #122876

This PR used to add extra logic to prevent those cases, but after #113169 this is implicitly rejected, because such usages are not defining.

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Apr 11, 2024

oli-obk changed the title~~Ensure opaque types can't have themselves as a hidden type with incompatible lifetimes~~ Test that opaque types can't have themselves as a hidden type with incompatible lifetimes

Jun 18, 2024

rustbot added the T-types

Relevant to the types team, which will review and decide on the PR/issue.

label

Jun 18, 2024

//! Test that we don't allow coercing an opaque type with a static
//! lifetime to a free version of itself. While this kind of
//! conversion is fine for rigid types, the hidden type behind an opaque
//! type may

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is incomplete? 🤔

pls fix test comment then r=me

@rustbot author

(so it is out of my review queue hehe)

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 18, 2024

@bors r=compiler-errors rollup

📌 Commit de473a5 has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 18, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 18, 2024

…r-errors

Test that opaque types can't have themselves as a hidden type with incompatible lifetimes

fixes rust-lang#122876

This PR used to add extra logic to prevent those cases, but after rust-lang#113169 this is implicitly rejected, because such usages are not defining.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 18, 2024

…r-errors

Test that opaque types can't have themselves as a hidden type with incompatible lifetimes

fixes rust-lang#122876

This PR used to add extra logic to prevent those cases, but after rust-lang#113169 this is implicitly rejected, because such usages are not defining.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 18, 2024

…llaumeGomez

Rollup of 9 pull requests

Successful merges:

rust-lang#123782 (Test that opaque types can't have themselves as a hidden type with incompatible lifetimes)
rust-lang#124580 (Suggest removing unused tuple fields if they are the last fields)
rust-lang#125852 (improve tip for inaccessible traits)
rust-lang#126422 (Suggest using a standalone doctest for non-local impl defs)
rust-lang#126427 (Rewrite intrinsic-unreachable, sepcomp-cci-copies, sepcomp-inlining and sepcomp-separate run-make tests to rmake.rs)
rust-lang#126493 (safe transmute: support non-ZST, variantful, uninhabited enums)
rust-lang#126572 (override user defined channel when using precompiled rustc)
rust-lang#126615 (Add rustc-ice* to .gitignore)
rust-lang#126632 (Replace move|| with move ||)

Failed merges:

rust-lang#126558 (hir_typeck: be more conservative in making "note caller chooses ty param" note)

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

…r-errors

Test that opaque types can't have themselves as a hidden type with incompatible lifetimes

fixes rust-lang#122876

This PR used to add extra logic to prevent those cases, but after rust-lang#113169 this is implicitly rejected, because such usages are not defining.

fmease added a commit to fmease/rust that referenced this pull request

Jun 19, 2024

…r-errors

Test that opaque types can't have themselves as a hidden type with incompatible lifetimes

fixes rust-lang#122876

This PR used to add extra logic to prevent those cases, but after rust-lang#113169 this is implicitly rejected, because such usages are not defining.

This was referenced

Jun 19, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

Rollup of 7 pull requests

Successful merges:

rust-lang#123782 (Test that opaque types can't have themselves as a hidden type with incompatible lifetimes)
rust-lang#124580 (Suggest removing unused tuple fields if they are the last fields)
rust-lang#125787 (Migrate bin-emit-no-symbols run-make test to rmake)
rust-lang#126553 (match lowering: expand or-candidates mixed with candidates above)
rust-lang#126594 (Make async drop code more consistent with regular drop code)
rust-lang#126654 (Make pretty printing for f16 and f128 consistent)
rust-lang#126656 (rustc_type_ir: Omit some struct fields from Debug output)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

Rollup merge of rust-lang#123782 - oli-obk:equal_tait_args, r=compiler-errors

Test that opaque types can't have themselves as a hidden type with incompatible lifetimes

fixes rust-lang#122876

This PR used to add extra logic to prevent those cases, but after rust-lang#113169 this is implicitly rejected, because such usages are not defining.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-types

Relevant to the types team, which will review and decide on the PR/issue.