Fix negating f16 and f128 constants by beetrees · Pull Request #124110 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks12 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Make f16 and f128 constants respect neg in parse_float_into_scalar.
Tracking issue: #116909
@rustbot label +F-f16_and_f128
r? @estebank
rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol this seems very easy to accidentally ignore (given that it was previously)
📌 Commit cc12a1b has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…errors
Fix negating f16 and f128 constants
Make f16 and f128 constants respect neg in parse_float_into_scalar.
Tracking issue: rust-lang#116909
@rustbot label +F-f16_and_f128
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…errors
Fix negating f16 and f128 constants
Make f16 and f128 constants respect neg in parse_float_into_scalar.
Tracking issue: rust-lang#116909
@rustbot label +F-f16_and_f128
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…errors
Fix negating f16 and f128 constants
Make f16 and f128 constants respect neg in parse_float_into_scalar.
Tracking issue: rust-lang#116909
@rustbot label +F-f16_and_f128
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 6 pull requests
Successful merges:
- rust-lang#117919 (Introduce perma-unstable
wasm-c-abiflag) - rust-lang#123571 (Correctly change type when adding adjustments on top of
NeverToAny) - rust-lang#123752 (Properly handle emojis as literal prefix in macros)
- rust-lang#123980 ( Add an opt-in to store incoming edges in
VecGraph+ misc) - rust-lang#124110 (Fix negating
f16andf128constants) - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation)
r? @ghost
@rustbot modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…errors
Fix negating f16 and f128 constants
Make f16 and f128 constants respect neg in parse_float_into_scalar.
Tracking issue: rust-lang#116909
@rustbot label +F-f16_and_f128
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 9 pull requests
Successful merges:
- rust-lang#117919 (Introduce perma-unstable
wasm-c-abiflag) - rust-lang#123406 (Force exhaustion in iter::ArrayChunks::into_remainder)
- rust-lang#123752 (Properly handle emojis as literal prefix in macros)
- rust-lang#123935 (Don't inline integer literals when they overflow - new attempt)
- rust-lang#123980 ( Add an opt-in to store incoming edges in
VecGraph+ misc) - rust-lang#124019 (Use raw-dylib for Windows synchronization functions)
- rust-lang#124110 (Fix negating
f16andf128constants) - rust-lang#124112 (Fix ICE when there is a non-Unicode entry in the incremental crate directory)
- rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 7 pull requests
Successful merges:
- rust-lang#123406 (Force exhaustion in iter::ArrayChunks::into_remainder)
- rust-lang#123752 (Properly handle emojis as literal prefix in macros)
- rust-lang#123935 (Don't inline integer literals when they overflow - new attempt)
- rust-lang#123980 ( Add an opt-in to store incoming edges in
VecGraph+ misc) - rust-lang#124019 (Use raw-dylib for Windows synchronization functions)
- rust-lang#124110 (Fix negating
f16andf128constants) - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#124110 - beetrees:neg-f16-f128, r=compiler-errors
Fix negating f16 and f128 constants
Make f16 and f128 constants respect neg in parse_float_into_scalar.
Tracking issue: rust-lang#116909
@rustbot label +F-f16_and_f128
Labels
`#![feature(f16)]`, `#![feature(f128)]`
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.