Add core::convert::absurd by WaffleLapkin · Pull Request #124311 · rust-lang/rust (original) (raw)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 20, 2024

…rovements, r=compiler-errors

Never type unsafe lint improvements

• Move linting code to a separate method
• Remove mentions of core::convert::absurd (rust-lang#124311 was rejected)
• Make the lint into FCW

The last thing is a bit weird though. On one hand it should be EditionSemanticsChange(2024), but on the other hand it shouldn't, because we also plan to break it on all editions some time later. Also, it's weird that we don't have FutureReleaseSemanticsChangeReportInDeps, IMO "this might cause UB in a future release" is important enough to be reported in deps...

IMO we ought to have three enums instead of FutureIncompatibilityReason:

enum IncompatibilityWhen {
     FutureRelease,
     Edition(Edition),
}

enum IncompatibilyWhat {
    Error,
    SemanticChange,
}

enum IncompatibilityReportInDeps {
    No,
    Yes,
}

Tracking:

• rust-lang#123748