Create const block DefIds in typeck instead of ast lowering by oli-obk · Pull Request #124650 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation49 Commits6 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
this is a prerequisite for cleaning up pattern types and the range pattern HIR nodes in general. Right now they contain expressions, but they are supposed to only contain constants. In order to generate the anonymous constants lazily during typeck, we need to support generating new items with bodies during typeck in general. Transforming const blocks was the simplest change I could find to allow us to do that (everything else is much more invasive if we haven't already done it for const blocks).
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Some changes occurred in match checking
cc @Nadrieril
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
Changes to the size of AST and/or HIR nodes.
cc @nnethercote
This comment has been minimized.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Create const block DefIds in typeck instead of ast lowering
r? @ghost
this is a prerequisite for cleaning up pattern types and the range pattern HIR nodes in general. Right now they contain expressions, but they are supposed to only contain constants. In order to generate the anonymous constants lazily during typeck, we need to support generating new items with bodies during typeck in general. Transforming const blocks was the simplest change I could find to allow us to do that (everything else is much more invasive if we haven't already done it for const blocks).
This comment has been minimized.
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…-params, r=spastorino
Pattern types: Prohibit generic args on const params
Addresses https://github.com/rust-lang/rust/pull/123689/files#r1562676629.
NB: Technically speaking, not prohibiting generics args on const params is not a bug as pattern_types is an internal feature and as such any uncaught misuses of it are considered to be the fault of the user. However, permitting this makes me slightly uncomfortable esp. since we might want to make pattern types available to the public at some point and I don't want this oversight to be able to slip into the language (for comparison, ICEs triggered by the use of internal features are like super fine).
Furthermore, this is an ad hoc fix. A more general fix would be changing the representation of the pattern part of pattern types in such a way that it can reuse preexisting lowering routines for exprs / anon consts. See also this Zulip discussion and rust-lang#124650.
Also note that we currently don't properly typeck the pattern of pat tys. This however is out of scope for this PR.
cc @oli-obk
r? @spastorino as discussed
Some changes occurred in src/tools/clippy
cc @rust-lang/clippy
This comment has been minimized.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Create const block DefIds in typeck instead of ast lowering
r? @ghost
this is a prerequisite for cleaning up pattern types and the range pattern HIR nodes in general. Right now they contain expressions, but they are supposed to only contain constants. In order to generate the anonymous constants lazily during typeck, we need to support generating new items with bodies during typeck in general. Transforming const blocks was the simplest change I could find to allow us to do that (everything else is much more invasive if we haven't already done it for const blocks).
This comment has been minimized.
☀️ Try build successful - checks-actions
Build commit: bbdee60 (bbdee6062d573cdaa8edbd300234a18adee59de9)
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (bbdee60): comparison URL.
Overall result: ❌✅ regressions and improvements - ACTION NEEDED
Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.
Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.
@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression
Instruction count
This is a highly reliable metric that was used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 1.4% | [0.2%, 4.6%] | 21 |
| Regressions ❌ (secondary) | 3.4% | [0.7%, 8.5%] | 5 |
| Improvements ✅ (primary) | -0.5% | [-0.6%, -0.4%] | 6 |
| Improvements ✅ (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | 1.0% | [-0.6%, 4.6%] | 27 |
Max RSS (memory usage)
Results (primary 1.4%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 1.8% | [1.2%, 3.5%] | 14 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -5.0% | [-5.0%, -5.0%] | 1 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 1.4% | [-5.0%, 3.5%] | 15 |
Cycles
Results (primary 1.8%, secondary 4.9%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 2.5% | [1.1%, 4.0%] | 6 |
| Regressions ❌ (secondary) | 4.9% | [1.8%, 8.9%] | 3 |
| Improvements ✅ (primary) | -2.2% | [-2.2%, -2.2%] | 1 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 1.8% | [-2.2%, 4.0%] | 7 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 672.666s -> 672.469s (-0.03%)
Artifact size: 315.47 MiB -> 315.47 MiB (-0.00%)
📌 Commit ac7e836 has been approved by nnethercote
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Finished benchmarking commit (7717a30): comparison URL.
Overall result: ❌✅ regressions and improvements - ACTION NEEDED
Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.
@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance
Instruction count
This is a highly reliable metric that was used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.2% | [0.2%, 0.2%] | 2 |
| Regressions ❌ (secondary) | 0.2% | [0.2%, 0.2%] | 3 |
| Improvements ✅ (primary) | -0.5% | [-0.6%, -0.3%] | 6 |
| Improvements ✅ (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | -0.3% | [-0.6%, 0.2%] | 8 |
Max RSS (memory usage)
Results (primary 1.1%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 1.1% | [0.6%, 1.6%] | 2 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 1.1% | [0.6%, 1.6%] | 2 |
Cycles
Results (primary -1.7%, secondary 2.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.6% | [2.6%, 2.6%] | 1 |
| Improvements ✅ (primary) | -1.7% | [-1.7%, -1.7%] | 1 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | -1.7% | [-1.7%, -1.7%] | 1 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 669.563s -> 669.344s (-0.03%)
Artifact size: 318.39 MiB -> 318.39 MiB (0.00%)
Tiny changes, and overall more gains than losses, probably not worth investigation effort imho.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r-errors
Reintroduce name resolution check for trying to access locals from an inline const
fixes rust-lang#125676
I removed this without replacement in rust-lang#124650 without considering the consequences
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r-errors
Reintroduce name resolution check for trying to access locals from an inline const
fixes rust-lang#125676
I removed this without replacement in rust-lang#124650 without considering the consequences
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#125705 - oli-obk:const_block_ice, r=compiler-errors
Reintroduce name resolution check for trying to access locals from an inline const
fixes rust-lang#125676
I removed this without replacement in rust-lang#124650 without considering the consequences
This was referenced
Jun 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r-errors
Revert: create const block bodies in typeck via query feeding
as per the discussion in rust-lang#125806 (comment)
It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed type_of to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.
reverts the const-block-specific parts of rust-lang#124650
@bors rollup=never had a small perf impact previously
fixes rust-lang#125846
r? @compiler-errors
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r-errors
Revert: create const block bodies in typeck via query feeding
as per the discussion in rust-lang#125806 (comment)
It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed type_of to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.
reverts the const-block-specific parts of rust-lang#124650
@bors rollup=never had a small perf impact previously
fixes rust-lang#125846
r? @compiler-errors
- as previously noted by @lqd : "Tiny changes, and overall more gains than losses, probably not worth investigation effort imho."
- marking as triaged
@rustbot label: +perf-regression-triaged
fmease added a commit to fmease/rust that referenced this pull request
…r-errors
Revert: create const block bodies in typeck via query feeding
as per the discussion in rust-lang#125806 (comment)
It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed type_of to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.
reverts the const-block-specific parts of rust-lang#124650
@bors rollup=never had a small perf impact previously
fixes rust-lang#125846
r? @compiler-errors
bors added a commit to rust-lang-ci/rust that referenced this pull request
…errors
Revert: create const block bodies in typeck via query feeding
as per the discussion in rust-lang#125806 (comment)
It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed type_of to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.
reverts the const-block-specific parts of rust-lang#124650
@bors rollup=never had a small perf impact previously
fixes rust-lang#125846
r? @compiler-errors
bors added a commit to rust-lang-ci/rust that referenced this pull request
…errors
Revert: create const block bodies in typeck via query feeding
as per the discussion in rust-lang#125806 (comment)
It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed type_of to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.
reverts the const-block-specific parts of rust-lang#124650
@bors rollup=never had a small perf impact previously
fixes rust-lang#125846
r? @compiler-errors
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request
Revert: create const block bodies in typeck via query feeding
as per the discussion in rust-lang/rust#125806 (comment)
It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed type_of to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.
reverts the const-block-specific parts of rust-lang/rust#124650
@bors rollup=never had a small perf impact previously
fixes rust-lang/rust#125846
r? @compiler-errors
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request
Revert: create const block bodies in typeck via query feeding
as per the discussion in rust-lang/rust#125806 (comment)
It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed type_of to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.
reverts the const-block-specific parts of rust-lang/rust#124650
@bors rollup=never had a small perf impact previously
fixes rust-lang/rust#125846
r? @compiler-errors