const-eval: make lint scope computation consistent by RalfJung · Pull Request #126388 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The first commit is some renaming for consistency, but otherwise unrelated. It just didn't feel worth a separate PR, but I can split this up if you prefer.
r? @oli-obk
Some changes occurred to the CTFE / Miri engine
cc @rust-lang/miri
Relevant to the compiler team, which will review and decide on the PR/issue.
label
📌 Commit 1f955a7 has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
| @@ -44,7 +45,7 @@ const TINY_LINT_TERMINATOR_LIMIT: usize = 20; |
|---|
| const PROGRESS_INDICATOR_START: usize = 4_000_000; |
| /// Extra machine state for CTFE, and the Machine instance |
| pub struct CompileTimeInterpreter<'tcx> { |
| pub struct CompileTimeMachine<'tcx> { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compile time-machine ⏰⏰⏰
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#126347 (Simplify
try_*'s signature onIterator) - rust-lang#126348 (Improve error message if dependency installation in tidy fails)
- rust-lang#126366 (Add a new trait to retrieve StableMir definition Ty)
- rust-lang#126370 (compiletest: Stricter parsing of
//@ normalize-*headers) - rust-lang#126379 (interpret: update doc comment for find_closest_untracked_caller_location)
- rust-lang#126384 (add tracking issue for is_none_or)
Failed merges:
- rust-lang#126388 (const-eval: make lint scope computation consistent)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
…ontext -> CompileTimeInterpCx
to match the terms used in the shared interpreter infrastructure
📌 Commit 54e24c1 has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#121216 (Always emit
native-static-libsnote, even if it is empty) - rust-lang#122613 (Don't build a broken/untested profiler runtime on mingw targets)
- rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates)
- rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns)
- rust-lang#126343 (Remove some msys2 utils)
- rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.)
- rust-lang#126399 (extend the check for LLVM build)
Failed merges:
- rust-lang#126388 (const-eval: make lint scope computation consistent)
r? @ghost
@rustbot modify labels: rollup
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
.......... (120/124)
...F (124/124)
/checkout/tests/rustdoc-gui/help-page.goml help-page... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` line 16
from `tests/rustdoc-gui/help-page.goml` line 23
from `tests/rustdoc-gui/help-page.goml` line 32: Error: Evaluation failed: The following errors happened: [localStorage item "rustdoc-theme" (of value "ayu") != "null"]: for command `assert-local-storage: {"rustdoc-theme": |theme|}`
Error: ()
Build completed unsuccessfully in 0:03:30
local time: Thu Jun 13 19:21:19 UTC 2024
network time: Thu, 13 Jun 2024 19:21:19 GMT
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…oli-obk
const-eval: make lint scope computation consistent
The first commit is some renaming for consistency, but otherwise unrelated. It just didn't feel worth a separate PR, but I can split this up if you prefer.
r? @oli-obk
This was referenced
Jun 13, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#126388 - RalfJung:const-eval-lint-scope, r=oli-obk
const-eval: make lint scope computation consistent
The first commit is some renaming for consistency, but otherwise unrelated. It just didn't feel worth a separate PR, but I can split this up if you prefer.
r? @oli-obk
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.