Change asm-comments to verbose-asm, always emit user comments by tgross35 · Pull Request #126803 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits3 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @ehuss
rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? @Amanieu feel free to reassign though
r=me once MCP is complete
This comment has been minimized.
Just rebased to fix the formatting change. It has been 10 days since the FCP so I think this can be merged, seems like the MCP labels on the issue just don't update automatically.
📌 Commit b079ac7 has been approved by Amanieu
It is now in the queue for this repository.
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#126403 (Actually report normalization-based type errors correctly for alias-relate obligations in new solver)
- rust-lang#126803 (Change
asm-commentstoverbose-asm, always emit user comments) - rust-lang#126917 (Disable rmake test
inaccessible-temp-diron riscv64) - rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit)
- rust-lang#127145 (Add
as_lang_itemtoLanguageItems, new trait solver) - rust-lang#127184 (More refactorings to rustc_interface)
- rust-lang#127202 (Remove global error count checks from typeck)
- rust-lang#127233 (Some parser cleanups)
- rust-lang#127245 (Add a test for
generic_const_exprs)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#126403 (Actually report normalization-based type errors correctly for alias-relate obligations in new solver)
- rust-lang#126803 (Change
asm-commentstoverbose-asm, always emit user comments) - rust-lang#126917 (Disable rmake test
inaccessible-temp-diron riscv64) - rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit)
- rust-lang#127145 (Add
as_lang_itemtoLanguageItems, new trait solver) - rust-lang#127184 (More refactorings to rustc_interface)
- rust-lang#127202 (Remove global error count checks from typeck)
- rust-lang#127233 (Some parser cleanups)
- rust-lang#127245 (Add a test for
generic_const_exprs)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Since this codegen flag now only controls LLVM-generated comments rather than all assembly comments, make the name more accurate (and also match Clang).
Made the test only check x86. @rustbot ready
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 1a6893e has been approved by Amanieu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#126803 (Change
asm-commentstoverbose-asm, always emit user comments) - rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit)
- rust-lang#127145 (Add
as_lang_itemtoLanguageItems, new trait solver) - rust-lang#127202 (Remove global error count checks from typeck)
- rust-lang#127233 (Some parser cleanups)
- rust-lang#127248 (Add parse fail test using safe trait/impl trait)
- rust-lang#127264 (Small
run-make-supportAPI improvements) - rust-lang#127270 (bootstrap: pass correct struct size to winapi)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
tgross35 added a commit to tgross35/rust-playground that referenced this pull request
This was referenced
Jul 4, 2024
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.