Migrate pdb-alt-path, mismatching-target-triples and mingw-export-call-convention run-make tests to rmake by Oneirical · Pull Request #126805 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation19 Commits3 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
@bors delegate+ (for try jobs)
✌️ @Oneirical, you can now approve this pull request!
If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
This comment has been minimized.
bors added a commit to rust-lang-ci/rust that referenced this pull request
☀️ Try build successful - checks-actions
Build commit: c00f017 (c00f017d0ce9ba2081e128de22a7b33ce59f92fd)
Sweet. The errors here had nothing to do with Windows permissions/structure, just me doing some standard silly compilation errors and not realizing it because some of these tests only run on Windows. @rustbot review
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Looks good, thanks!
@bors r+
📌 Commit a2ed16c has been approved by Kobzol
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#126805 (Migrate
pdb-alt-path,mismatching-target-triplesandmingw-export-call-conventionrun-maketests to rmake) - rust-lang#126995 (Migrate
pretty-print-with-dep-file,pretty-print-to-fileandlibtest-paddingrun-maketests to rmake) - rust-lang#127041 (Migrate
run-make/override-aliased-flagstormake.rs) - rust-lang#127072 (docs: say "includes" instead of "does include")
- rust-lang#127073 (Remove unnecessary SeqCst in
impl fmt::Pointer for AtomicPtr) - rust-lang#127112 (Bootstrap: Don't get output if
lldb --versionerrors) - rust-lang#127116 (Migrate
run-make/return-non-c-like-enumtormake.rs)
Failed merges:
- rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)