linker: Refactor interface for passing arguments to linker by petrochenkov · Pull Request #126832 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation18 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both.
Also avoid allocations in all the argument passing functions.
The interfaces would look nicer if not the limitations on returning &mut Self in dyn-compatible traits, and unnecessary conflicts between Trait and dyn Trait methods.
try-job: armhf-gnu
try-job: aarch64-gnu
try-job: dist-x86_64-linux
try-job: x86_64-msvc
try-job: i686-msvc
try-job: dist-x86_64-apple
try-job: test-various
r? @BoxyUwU
rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the changes look good, I'll throw it at a bunch of random try jobs in case some test somewhere catches any unintended changes. If the try jobs come back green, then r=me!
bors added a commit to rust-lang-ci/rust that referenced this pull request
linker: Refactor interface for passing arguments to linker
Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions.
The interfaces would look nicer if not the limitations on returning &mut Self in dyn-compatible traits, and unnecessary conflicts between Trait and dyn Trait methods.
try-job: armhf-gnu try-job: aarch64-gnu try-job: dist-x86_64-linux try-job: x86_64-msvc try-job: i686-msvc try-job: dist-x86_64-apple try-job: test-various
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
From looking at the code it's not clear how this may happen for --target=wasm32-wasip1, let's try again with some additional debugging.
@bors try
bors added a commit to rust-lang-ci/rust that referenced this pull request
linker: Refactor interface for passing arguments to linker
Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions.
The interfaces would look nicer if not the limitations on returning &mut Self in dyn-compatible traits, and unnecessary conflicts between Trait and dyn Trait methods.
try-job: test-various
This comment has been minimized.
bors added a commit to rust-lang-ci/rust that referenced this pull request
linker: Refactor interface for passing arguments to linker
Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions.
The interfaces would look nicer if not the limitations on returning &mut Self in dyn-compatible traits, and unnecessary conflicts between Trait and dyn Trait methods.
try-job: armhf-gnu try-job: aarch64-gnu try-job: dist-x86_64-linux try-job: x86_64-msvc try-job: i686-msvc try-job: dist-x86_64-apple try-job: test-various
☀️ Try build successful - checks-actions
Build commit: 89280e1 (89280e16f1e6b7aaeebe74303dc6db3c4cdc7b20)
📌 Commit 5f9a0d3 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#126732 (Stabilize
PanicInfo::message()andPanicMessage) - rust-lang#126753 (Add nightly style guide section for
precise_capturinguse<>syntax) - rust-lang#126832 (linker: Refactor interface for passing arguments to linker)
- rust-lang#126880 (Migrate
volatile-intrinsics,weird-output-filenames,wasm-override-linker,wasm-exceptions-nostdtormake) - rust-lang#127128 (Stabilize
duration_abs_diff) - rust-lang#127129 (Use full expr span for return suggestion on type error/ambiguity)
- rust-lang#127188 ( improve the way bootstrap handles rustlib components)
- rust-lang#127201 (Improve run-make-support API)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#126832 - petrochenkov:linkarg, r=jieyouxu
linker: Refactor interface for passing arguments to linker
Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions.
The interfaces would look nicer if not the limitations on returning &mut Self in dyn-compatible traits, and unnecessary conflicts between Trait and dyn Trait methods.
try-job: armhf-gnu try-job: aarch64-gnu try-job: dist-x86_64-linux try-job: x86_64-msvc try-job: i686-msvc try-job: dist-x86_64-apple try-job: test-various
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.