coverage: Restrict ExpressionUsed simplification to Code mappings by Zalathar · Pull Request #127758 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This makes it possible to allocate per-BCB data structures without needing access to the whole graph.
In the future, branch and MC/DC mappings might have expressions that don't
correspond to any single point in the control-flow graph. That makes it
trickier to keep track of which expressions should expect an ExpressionUsed
node.
We therefore sidestep that complexity by only performing ExpressionUsed
simplification for expressions associated directly with ordinary Code
mappings.
r? @oli-obk
rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
📌 Commit d4f1f92 has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
coverage: Restrict ExpressionUsed simplification to Code mappings
In the future, branch and MC/DC mappings might have expressions that don't correspond to any single point in the control-flow graph. That makes it trickier to keep track of which expressions should expect an ExpressionUsed node.
We therefore sidestep that complexity by only performing ExpressionUsed simplification for expressions associated directly with ordinary Code mappings.
(This simplification step is inherited from the original coverage implementation, which only supported Code mappings anyway, so there's no particular reason to extend it to other kinds of mappings unless we specifically choose to.)
Relevant to:
@rustbot label +A-code-coverage
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#124921 (offset_from: always allow pointers to point to the same address)
- rust-lang#127407 (Make parse error suggestions verbose and fix spans)
- rust-lang#127675 (Remove invalid help diagnostics for const pointer)
- rust-lang#127684 (consolidate miri-unleashed tests for mutable refs into one file)
- rust-lang#127758 (coverage: Restrict
ExpressionUsedsimplification toCodemappings)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
coverage: Restrict ExpressionUsed simplification to Code mappings
In the future, branch and MC/DC mappings might have expressions that don't correspond to any single point in the control-flow graph. That makes it trickier to keep track of which expressions should expect an ExpressionUsed node.
We therefore sidestep that complexity by only performing ExpressionUsed simplification for expressions associated directly with ordinary Code mappings.
(This simplification step is inherited from the original coverage implementation, which only supported Code mappings anyway, so there's no particular reason to extend it to other kinds of mappings unless we specifically choose to.)
Relevant to:
@rustbot label +A-code-coverage
This was referenced
Jul 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#124921 (offset_from: always allow pointers to point to the same address)
- rust-lang#127407 (Make parse error suggestions verbose and fix spans)
- rust-lang#127684 (consolidate miri-unleashed tests for mutable refs into one file)
- rust-lang#127729 (Stop using the
genidentifier in the compiler) - rust-lang#127736 (Add myself to the review rotation)
- rust-lang#127758 (coverage: Restrict
ExpressionUsedsimplification toCodemappings)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#127758 - Zalathar:expression-used, r=oli-obk
coverage: Restrict ExpressionUsed simplification to Code mappings
In the future, branch and MC/DC mappings might have expressions that don't correspond to any single point in the control-flow graph. That makes it trickier to keep track of which expressions should expect an ExpressionUsed node.
We therefore sidestep that complexity by only performing ExpressionUsed simplification for expressions associated directly with ordinary Code mappings.
(This simplification step is inherited from the original coverage implementation, which only supported Code mappings anyway, so there's no particular reason to extend it to other kinds of mappings unless we specifically choose to.)
Relevant to:
@rustbot label +A-code-coverage
Labels
Area: Source-based code coverage (-Cinstrument-coverage)
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.