Fix git safe-directory path for docker images by ehuss · Pull Request #127839 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This fixes the path for configuring the git safe.directory setting inside docker images. AFAIK, ~/gitconfig without a dot is not something that git uses (ref). This was needed in my environment to avoid the fatal: detected dubious ownership in repository at '/checkout' error. For context, this was added in #99967.

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the infrastructure team, which will review and decide on the PR/issue.

labels

📌 Commit 572ba97 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

bors added a commit to rust-lang-ci/rust that referenced this pull request

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

…k-Simulacrum

Fix git safe-directory path for docker images

This fixes the path for configuring the git safe.directory setting inside docker images. AFAIK, ~/gitconfig without a dot is not something that git uses (ref). This was needed in my environment to avoid the fatal: detected dubious ownership in repository at '/checkout' error. For context, this was added in rust-lang#99967.

bors added a commit to rust-lang-ci/rust that referenced this pull request

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Rollup merge of rust-lang#127839 - ehuss:safe-directory-docker, r=Mark-Simulacrum

Fix git safe-directory path for docker images

This fixes the path for configuring the git safe.directory setting inside docker images. AFAIK, ~/gitconfig without a dot is not something that git uses (ref). This was needed in my environment to avoid the fatal: detected dubious ownership in repository at '/checkout' error. For context, this was added in rust-lang#99967.

bors added a commit to rust-lang-ci/rust that referenced this pull request

…mpiler-errors

Rollup of 7 pull requests

Successful merges:

rust-lang#126450 (Promote Mac Catalyst targets to Tier 2, and ship with rustup)
rust-lang#127177 (Distribute rustc_codegen_cranelift for arm64 macOS)
rust-lang#127510 (Rewrite test-float-parse in Rust)
rust-lang#127720 ([macro_metavar_expr_concat] Allow concat in repetitions)
rust-lang#127734 (Windows: move BSD socket shims to netc)
rust-lang#127839 (Fix git safe-directory path for docker images)
rust-lang#128005 (Remove _tls_used hack)

r? @ghost @rustbot modify labels: rollup

Labels

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Relevant to the infrastructure team, which will review and decide on the PR/issue.