Migrate test-benches, c-unwind-abi-catch-panic and compiler-lookup-paths-2 run-make tests to rmake by Oneirical · Pull Request #127985 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits3 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left one nit, but I don't think it's super important. Feel free to r=me with or without fixing it.
r? @Kobzol
| use run_make_support::{run, run_with_args, rustc}; |
|---|
| fn main() { |
| rustc().arg("--test").input("smokebench.rs").opt().run(); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Smoke-test that #[bench] isn't entirely broken.
I think we could keep the original comment here.
✌️ @Oneirical, you can now approve this pull request!
If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol
📌 Commit 2192a91 has been approved by Kobzol
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#126450 (Promote Mac Catalyst targets to Tier 2, and ship with rustup)
- rust-lang#127177 (Distribute rustc_codegen_cranelift for arm64 macOS)
- rust-lang#127510 (Rewrite
test-float-parsein Rust) - rust-lang#127977 (Update wasi-sdk in CI to latest release)
- rust-lang#127985 (Migrate
test-benches,c-unwind-abi-catch-panicandcompiler-lookup-paths-2run-maketests to rmake) - rust-lang#128023 (rustdoc: short descriptions cause word-breaks in tables)
r? @ghost
@rustbot modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#126450 (Promote Mac Catalyst targets to Tier 2, and ship with rustup)
- rust-lang#127177 (Distribute rustc_codegen_cranelift for arm64 macOS)
- rust-lang#127583 (Deal with invalid UTF-8 from
gai_strerror) - rust-lang#127977 (Update wasi-sdk in CI to latest release)
- rust-lang#127985 (Migrate
test-benches,c-unwind-abi-catch-panicandcompiler-lookup-paths-2run-maketests to rmake) - rust-lang#128014 (Fix stab display in doc blocks)
- rust-lang#128023 (rustdoc: short descriptions cause word-breaks in tables)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)