Do not ICE with incorrect empty suggestion by estebank · Pull Request #127988 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
When we have two types with the same name, one without type parameters and the other with type parameters and a derive macro, we were before incorrectly suggesting to remove type parameters from the former, which ICEd because we were suggesting to remove nothing. We now gate against this.
The output is still not perfect. E0107 should explicitly detect this case and provide better context, but for now let's avoid the ICE.
Fix #108748.
r? @fmease
rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment was marked as resolved.
This comment has been minimized.
Was #109082 closed due to perf regressions?
@fmease yes. Couldn't figure out how to mitigate them.
When we have two types with the same name, one without type parameters and the other with type parameters and a derive macro, we were before incorrectly suggesting to remove type parameters from the former, which ICEd because we were suggesting to remove nothing. We now gate against this.
The output is still not perfect. E0107 should explicitly detect this case and provide better context, but for now let's avoid the ICE.
Silences rust-log-analyzer postings to the PR it's added on.
label
Silences rust-log-analyzer postings to the PR it's added on.
label
I've pushed an extra commit that makes it clear that this is a HACK.
@bors r+ rollup (diagnostic code path)
📌 Commit 682c5f4 has been approved by fmease
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
Do not ICE with incorrect empty suggestion
When we have two types with the same name, one without type parameters and the other with type parameters and a derive macro, we were before incorrectly suggesting to remove type parameters from the former, which ICEd because we were suggesting to remove nothing. We now gate against this.
The output is still not perfect. E0107 should explicitly detect this case and provide better context, but for now let's avoid the ICE.
Fix rust-lang#108748.
This was referenced
Sep 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 9 pull requests
Successful merges:
- rust-lang#97524 (Add
Thread::{into_raw, from_raw}) - rust-lang#127988 (Do not ICE with incorrect empty suggestion)
- rust-lang#129422 (Gate
repr(Rust)correctly on non-ADT items) - rust-lang#129934 (Win: Open dir for sync access in remove_dir_all)
- rust-lang#130450 (Reduce confusion about
make_indirect_byvalby renaming it) - rust-lang#130476 (Implement ACP 429: add
Lazy{Cell,Lock}::get[_mut]andforce_mut) - rust-lang#130487 (Update the minimum external LLVM to 18)
- rust-lang#130513 (Clarify docs for std::fs::File::write)
- rust-lang#130522 ([Clippy] Swap
manual_retainto use diagnostic items instead of paths)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#127988 - estebank:dupe-derive-params, r=fmease
Do not ICE with incorrect empty suggestion
When we have two types with the same name, one without type parameters and the other with type parameters and a derive macro, we were before incorrectly suggesting to remove type parameters from the former, which ICEd because we were suggesting to remove nothing. We now gate against this.
The output is still not perfect. E0107 should explicitly detect this case and provide better context, but for now let's avoid the ICE.
Fix rust-lang#108748.
Labels
Area: Messages for errors, warnings, and lints
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.