make it possible to disable download-rustc if it's incompatible by onur-ozkan · Pull Request #128098 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Primarily needed by CI runners to avoid handling download-rustc incompatible options one by one on shell scripts.
This will significantly help to #122709.
Primarily needed by CI runners to avoid handling download-rustc incompatible options one by one on shell scripts.
Signed-off-by: onur-ozkan work@onurozkan.dev
r? @Kobzol
rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, although random env. vars are hard to discover (maybe we should at least document this in config.example.toml?). What do you think about just using a different mode instead? Something like rust.download-rustc = "if-compatible".
Looks fine, although random env. vars are hard to discover (maybe we should at least document this in
config.example.toml?). What do you think about just using a different mode instead? Something likerust.download-rustc = "if-compatible".
I think adding another mode to download-rustc makes it complicated than it should be. We only need this for CI and no one should need/use it for local development. As for documenting it, I can make a follow-up PR on https://github.com/rust-lang/rustc-dev-guide.
Right, I considered this to also be user-facing, because I myself had a use-case for it 😆 (as we discussed on Zulip). If it's really only for CI, then fine by me.
@bors r+
📌 Commit d4f3673 has been approved by Kobzol
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#125886 (Migrate run make issue 15460)
- rust-lang#126898 (Migrate
run-make/link-frameworktormake.rs) - rust-lang#126994 (Support lists and stylings in more places for
rustc --explain) - rust-lang#127990 (Migrate
lto-linkage-used-attr,no-duplicate-libsandpgo-gen-no-imp-symbolsrun-maketests to rmake) - rust-lang#128060 (Fix inclusion of
wasm-component-ldin dist artifacts) - rust-lang#128082 (Note closure captures when reporting cast to fn ptr failed)
- rust-lang#128098 (make it possible to disable download-rustc if it's incompatible)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#128098 - onur-ozkan:incompatible-option-behaviour, r=Kobzol
make it possible to disable download-rustc if it's incompatible
Primarily needed by CI runners to avoid handling download-rustc incompatible options one by one on shell scripts.
This will significantly help to rust-lang#122709.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)