rustdoc: change title of search results by lolbinarycat · Pull Request #128210 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

the current title is too similar to that of the page for std::result::Result, which is a problem both for
navigating to the Result docs via browser autocomplete, and for being able to tell which tab is which when the width of tabs is small.

the current title is too similar to that of the page for std::result::Result, which is a problem both for navigating to the Result docs via browser autocomplete, and for being able to tell which tab is which when the width of tabs is small.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fmease (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Jul 25, 2024

This comment has been minimized.

I don't have an opinion here. Maybe you do @notriddle ?

AFAICT, the format for search titles was introduced in this PR: #26401

The current format for document titles was introduced in this PR: #84380

Neither PR seems to have put as much thought into the SERP titles as @lolbinarycat has, and their reasoning makes sense. Let's go with it. 👍

📌 Commit 587b64e has been approved by notriddle,GuillaumeGomez

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 26, 2024

tgross35 added a commit to tgross35/rust that referenced this pull request

Jul 26, 2024

… r=notriddle,GuillaumeGomez

rustdoc: change title of search results

the current title is too similar to that of the page for std::result::Result, which is a problem both for navigating to the Result docs via browser autocomplete, and for being able to tell which tab is which when the width of tabs is small.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 26, 2024

Rollup of 9 pull requests

Successful merges:

rust-lang#121676 (Support ?Trait bounds in supertraits and dyn Trait under a feature gate)
rust-lang#124941 (Stabilize const {integer}::from_str_radix i.e. const_int_from_str)
rust-lang#128210 (rustdoc: change title of search results)
rust-lang#128223 (Refactor complex conditions in collect_tokens_trailing_token)
rust-lang#128224 (Remove unnecessary range replacements)
rust-lang#128226 (Remove redundant option that was just encoding that a slice was empty)
rust-lang#128227 (CI: do not respect custom try jobs for unrolled perf builds)
rust-lang#128229 (Improve extern "<abi>" unsafe fn() error message)
rust-lang#128235 (Fix Iterator::filter docs)

r? @ghost @rustbot modify labels: rollup

tgross35 added a commit to tgross35/rust that referenced this pull request

Jul 26, 2024

… r=notriddle,GuillaumeGomez

rustdoc: change title of search results

the current title is too similar to that of the page for std::result::Result, which is a problem both for navigating to the Result docs via browser autocomplete, and for being able to tell which tab is which when the width of tabs is small.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 26, 2024

Rollup of 9 pull requests

Successful merges:

rust-lang#124941 (Stabilize const {integer}::from_str_radix i.e. const_int_from_str)
rust-lang#127853 (#[naked]: report incompatible attributes)
rust-lang#128210 (rustdoc: change title of search results)
rust-lang#128223 (Refactor complex conditions in collect_tokens_trailing_token)
rust-lang#128224 (Remove unnecessary range replacements)
rust-lang#128226 (Remove redundant option that was just encoding that a slice was empty)
rust-lang#128227 (CI: do not respect custom try jobs for unrolled perf builds)
rust-lang#128229 (Improve extern "<abi>" unsafe fn() error message)
rust-lang#128235 (Fix Iterator::filter docs)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 27, 2024

Rollup of 9 pull requests

Successful merges:

rust-lang#124941 (Stabilize const {integer}::from_str_radix i.e. const_int_from_str)
rust-lang#128201 (Implement Copy/Clone for async closures)
rust-lang#128210 (rustdoc: change title of search results)
rust-lang#128223 (Refactor complex conditions in collect_tokens_trailing_token)
rust-lang#128224 (Remove unnecessary range replacements)
rust-lang#128226 (Remove redundant option that was just encoding that a slice was empty)
rust-lang#128227 (CI: do not respect custom try jobs for unrolled perf builds)
rust-lang#128229 (Improve extern "<abi>" unsafe fn() error message)
rust-lang#128235 (Fix Iterator::filter docs)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jul 27, 2024

Rollup merge of rust-lang#128210 - lolbinarycat:rustdoc-search-title, r=notriddle,GuillaumeGomez

rustdoc: change title of search results

the current title is too similar to that of the page for std::result::Result, which is a problem both for navigating to the Result docs via browser autocomplete, and for being able to tell which tab is which when the width of tabs is small.

tgross35 added a commit to tgross35/rust that referenced this pull request

Jul 27, 2024

…otriddle

Add rustdoc GUI test to check title with and without search

Follow-up of rust-lang#128210.

r? @notriddle

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jul 27, 2024

Rollup merge of rust-lang#128267 - GuillaumeGomez:gui-test-title, r=notriddle

Add rustdoc GUI test to check title with and without search

Follow-up of rust-lang#128210.

r? @notriddle