Migrate `remap-path-prefix-dwarf` `run-make` test to rmake by Oneirical · Pull Request #128410 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation25 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Part of #121876 and the associated Google Summer of Code project.

Possibly my proudest branch name yet.

try-job: aarch64-apple
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-gnu-llvm-18

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jul 30, 2024

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 30, 2024

This comment has been minimized.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 31, 2024

Ignore restored, reason added. @rustbot review

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

fn main() {
// The compiler is called with an ABSOLUTE PATH as input, and that absolute path is within
// the working directory of the compiler. We are remapping the path that contains `src`.
check_dwarf(DwarfTest {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: this organization is very nice 👍

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 3, 2024

☀️ Try build successful - checks-actions
Build commit: 5975414 (597541447dbac0d2aafa502613a6181ef184c141)

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 8, 2024

…

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: dist-various-1

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 8, 2024

…

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

try-job: aarch64-apple

try-job: test-various try-job: armhf-gnu try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 9, 2024

…iaskrgr

Rollup of 4 pull requests

Successful merges:

rust-lang#128616 (Don't inline tainted MIR bodies)
rust-lang#128804 (run-make: enable msvc for redundant-libs)
rust-lang#128823 (run-make: enable msvc for staticlib-dylib-linkage)
rust-lang#128824 (Update compiler-builtins version to 0.1.118)

Failed merges:

rust-lang#128410 (Migrate remap-path-prefix-dwarf run-make test to rmake)

r? @ghost @rustbot modify labels: rollup

@bors r- (needs a rebase)

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Aug 11, 2024

@bors delegate+ (r=me after rebase)

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

📌 Commit fe52572 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 12, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Aug 13, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 13, 2024

…llaumeGomez

Rollup of 7 pull requests

Successful merges:

rust-lang#127857 (Allow to customize // TODO: comment for deprecated safe autofix)
rust-lang#128410 (Migrate remap-path-prefix-dwarf run-make test to rmake)
rust-lang#128828 (-Znext-solver caching)
rust-lang#128873 (Add windows-targets crate to std's sysroot)
rust-lang#129034 (Add #[must_use] attribute to Coroutine trait)
rust-lang#129049 (compiletest: Don't panic on unknown JSON-like output lines)
rust-lang#129050 (Emit a warning instead of an error if --generate-link-to-definition is used with other output formats than HTML)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 14, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

rust-lang#128410 (Migrate remap-path-prefix-dwarf run-make test to rmake)
rust-lang#128759 (alloc: add ToString specialization for &&str)
rust-lang#128873 (Add windows-targets crate to std's sysroot)
rust-lang#129001 (chore(lib): Enhance documentation for core::fmt::Formatter's write_fm…)
rust-lang#129061 (Use is_lang_item more)
rust-lang#129062 (Remove a no-longer-true assert)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 14, 2024

…

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 14, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 14, 2024

…

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 14, 2024

…

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

// try-job: aarch64-apple // try-job: aarch64-gnu // try-job: armhf-gnu // try-job: test-various // try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 15, 2024

…

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 16, 2024

…

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

// try-job: x86_64-msvc // windows jobs passed in a prior run // try-job: x86_64-mingw // try-job: i686-msvc // try-job: i686-mingw try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various try-job: dist-various-1

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 16, 2024

…jieyouxu

Migrate reproducible-build run-make test to rmake

Part of rust-lang#121876 and the associated Google Summer of Code project.

This will likely fail. Locally, rustc errors with linker 'linker' not found on line 36 while the file exists according to the dir-debug statement before it.

If this gets fixed and the test passes, further developments may include:

There may be some leftovers from each test - test_in_tmpdir may therefore be required.
Try jobs on all ignored architectures.
A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of rfs and rustc. This is a little bit harder to do in this test considering the variability present in each test case.

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Migrate remap-path-prefix-dwarf run-make test to rmake by Oneirical · Pull Request #128410 · rust-lang/rust (original) (raw)

Conversation

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

try-job: aarch64-apple

Migrate `remap-path-prefix-dwarf` `run-make` test to rmake by Oneirical · Pull Request #128410 · rust-lang/rust (original) (raw)