Assert that all attributes are actually checked via CheckAttrVisitor and aren't accidentally usable on completely unrelated HIR nodes by oli-obk · Pull Request #128444 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
based on #128402
After this PR, adding a new attribute will ICE on any use of that attribute unless it gets a handler added.
r? @nnethercote
rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
…` and aren't accidentally usable on completely unrelated HIR nodes
I will not be able to resolve feedback to this PR as I'm going on 4 months of leave later today. If possible, please just push to my branch and land things or open a new PR.
📌 Commit d210561 has been approved by nnethercote
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This was referenced
Aug 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Assert that all attributes are actually checked via CheckAttrVisitor and aren't accidentally usable on completely unrelated HIR nodes
based on rust-lang#128402
After this PR, adding a new attribute will ICE on any use of that attribute unless it gets a handler added.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Opened #128581 with the changes in this PR, but with the unreachable case removed.
tgross35 added a commit to tgross35/rust that referenced this pull request
Assert that all attributes are actually checked via CheckAttrVisitor and aren't accidentally usable on completely unrelated HIR nodes
@oli-obk's rust-lang#128444 with unreachable case removed to avoid that PR bitrotting away.
Based on rust-lang#128402.
This PR will make adding a new attribute ICE on any use of that attribute unless it gets a handler added in rustc_passes::CheckAttrVisitor.
r? @nnethercote (since you were the reviewer of the original PR)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Assert that all attributes are actually checked via CheckAttrVisitor and aren't accidentally usable on completely unrelated HIR nodes
@oli-obk's rust-lang#128444 with unreachable case removed to avoid that PR bitrotting away.
Based on rust-lang#128402.
This PR will make adding a new attribute ICE on any use of that attribute unless it gets a handler added in rustc_passes::CheckAttrVisitor.
r? @nnethercote (since you were the reviewer of the original PR)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#128581 - jieyouxu:checked-attr, r=nnethercote
Assert that all attributes are actually checked via CheckAttrVisitor and aren't accidentally usable on completely unrelated HIR nodes
@oli-obk's rust-lang#128444 with unreachable case removed to avoid that PR bitrotting away.
Based on rust-lang#128402.
This PR will make adding a new attribute ICE on any use of that attribute unless it gets a handler added in rustc_passes::CheckAttrVisitor.
r? @nnethercote (since you were the reviewer of the original PR)
Labels
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the compiler team, which will review and decide on the PR/issue.