Migrate staticlib-dylib-linkage run-make test to rmake by Oneirical · Pull Request #128696 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation15 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Aug 5, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems reasonable, just a few nits.

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 5, 2024

☀️ Try build successful - checks-actions
Build commit: 0bebf25 (0bebf25e823c1e13d85d9553a26145b387ec95b1)

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

All review remarks applied. @rustbot review

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 6, 2024

Thanks, r=me after CI is green
@bors delegate+ rollup=iffy

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

📌 Commit 608b322 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 6, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Aug 7, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

…iaskrgr

Rollup of 5 pull requests

Successful merges:

• rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries)
• rust-lang#128407 (Migrate min-global-align and no-alloc-shim run-make tests to rmake)
• rust-lang#128584 (Add a set of tests for LLVM 19)
• rust-lang#128636 (migrate thumb-none-cortex-m to rmake)
• rust-lang#128696 (Migrate staticlib-dylib-linkage run-make test to rmake)

Failed merges:

• rust-lang#128639 (migrate thumb-none-qemu to rmake)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

…iaskrgr

Rollup of 4 pull requests

Successful merges:

• rust-lang#128363 (Migrate pdb-buildinfo-cl-cmd and pgo-indirect-call-promotion run-make tests to rmake)
• rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries)
• rust-lang#128636 (migrate thumb-none-cortex-m to rmake)
• rust-lang#128696 (Migrate staticlib-dylib-linkage run-make test to rmake)

Failed merges:

• rust-lang#128407 (Migrate min-global-align and no-alloc-shim run-make tests to rmake)
• rust-lang#128639 (migrate thumb-none-qemu to rmake)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 8, 2024

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)