Ship MinGW-w64 runtime DLLs along with rust-lld.exe for -pc-windows-gnu targets by ColinFinck · Pull Request #128876 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Aug 9, 2024

…s-gnu` targets

rust-lld.exe built for x86_64-pc-windows-gnu depends on libgcc_s_seh-1.dll and libwinpthread-1.dll from MinGW-w64. Until now, they were not shipped alongside rust-lld.exe, and you could not run rust-lld.exe on most systems.

This problem didn't surface until now because:

• Most targets don't use rust-lld by default.
• Some people had these DLLs in their PATH from some other MinGW binary.
• rustup used to add bin to the PATH, which contains these DLLs for rustc.exe. But it no longer does that: rust-lang/rustup@ce3c09a

Fixes rust-lang#125809

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 22, 2024

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 22, 2024

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 22, 2024

…lls, r=Kobzol,petrochenkov,jieyouxu

Ship MinGW-w64 runtime DLLs along with rust-lld.exe for -pc-windows-gnu targets

rust-lld.exe built for x86_64-pc-windows-gnu depends on libgcc_s_seh-1.dll and libwinpthread-1.dll from MinGW-w64. Until now, they were not shipped alongside rust-lld.exe, and you could not run rust-lld.exe on most systems.

This problem didn't surface until now because:

• Most targets don't use rust-lld by default.
• Some people had these DLLs in their PATH from some other MinGW binary.
• rustup used to add bin to the PATH, which contains these DLLs for rustc.exe. But it no longer does that: rust-lang/rustup@ce3c09a

Fixes rust-lang#125809

try-job: dist-x86_64-mingw

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024

Rollup of 7 pull requests

Successful merges:

• rust-lang#126985 (Implement -Z embed-source (DWARFv5 source code embedding extension))
• rust-lang#128349 (Enable f16 on x86 and x86-64)
• rust-lang#128876 (Ship MinGW-w64 runtime DLLs along with rust-lld.exe for -pc-windows-gnu targets)
• rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
• rust-lang#129257 (Allow rust staticlib to work with MSVC's /WHOLEARCHIVE)
• rust-lang#129386 (Use a LocalDefId in ResolvedArg.)
• rust-lang#129400 (Update compiler_builtins to 0.1.120)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 23, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success)
• rust-lang#128876 (Ship MinGW-w64 runtime DLLs along with rust-lld.exe for -pc-windows-gnu targets)
• rust-lang#129055 (Migrate x86_64-fortanix-unknown-sgx-lvi run-make test to rmake)
• rust-lang#129386 (Use a LocalDefId in ResolvedArg.)
• rust-lang#129400 (Update compiler_builtins to 0.1.120)
• rust-lang#129414 (Fix extern crates not being hidden with doc(hidden))
• rust-lang#129417 (Don't trigger refinement lint if predicates reference errors)
• rust-lang#129433 (Fix a missing import in a doc in run-make-support)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 23, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success)
• rust-lang#128876 (Ship MinGW-w64 runtime DLLs along with rust-lld.exe for -pc-windows-gnu targets)
• rust-lang#129055 (Migrate x86_64-fortanix-unknown-sgx-lvi run-make test to rmake)
• rust-lang#129386 (Use a LocalDefId in ResolvedArg.)
• rust-lang#129400 (Update compiler_builtins to 0.1.120)
• rust-lang#129414 (Fix extern crates not being hidden with doc(hidden))
• rust-lang#129417 (Don't trigger refinement lint if predicates reference errors)
• rust-lang#129433 (Fix a missing import in a doc in run-make-support)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 23, 2024

Rollup merge of rust-lang#128876 - ColinFinck:rust-lld-with-runtime-dlls, r=Kobzol,petrochenkov,jieyouxu

Ship MinGW-w64 runtime DLLs along with rust-lld.exe for -pc-windows-gnu targets

rust-lld.exe built for x86_64-pc-windows-gnu depends on libgcc_s_seh-1.dll and libwinpthread-1.dll from MinGW-w64. Until now, they were not shipped alongside rust-lld.exe, and you could not run rust-lld.exe on most systems.

This problem didn't surface until now because:

• Most targets don't use rust-lld by default.
• Some people had these DLLs in their PATH from some other MinGW binary.
• rustup used to add bin to the PATH, which contains these DLLs for rustc.exe. But it no longer does that: rust-lang/rustup@ce3c09a

Fixes rust-lang#125809

try-job: dist-x86_64-mingw