Slightly refactor Flags in bootstrap by Kobzol · Pull Request #128878 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation15 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The next step for #126819 is to track commands executed inside Config::parse. This is quite challenging, because (tracked) command execution needs to access some state that is stored inside Config, which creates a sort of a chicken-and-egg problem.
I would like to first untangle Config::parse a little bit, which is what this PR starts with.
Tracking issue: #126819
r? @onur-ozkan
To remove a side effect (process exit) when parsing config.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@bors r=onur-ozkan rollup
📌 Commit 5431a93 has been approved by onur-ozkan
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Slightly refactor Flags in bootstrap
The next step for rust-lang#126819 is to track commands executed inside Config::parse. This is quite challenging, because (tracked) command execution needs to access some state that is stored inside Config, which creates a sort of a chicken-and-egg problem.
I would like to first untangle Config::parse a little bit, which is what this PR starts with.
Tracking issue: rust-lang#126819
r? @onur-ozkan
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
This conflicts with #128977. Needs to be merged after it.
📌 Commit 5431a93 has been approved by onur-ozkan
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Slightly refactor Flags in bootstrap
The next step for rust-lang#126819 is to track commands executed inside Config::parse. This is quite challenging, because (tracked) command execution needs to access some state that is stored inside Config, which creates a sort of a chicken-and-egg problem.
I would like to first untangle Config::parse a little bit, which is what this PR starts with.
Tracking issue: rust-lang#126819
r? @onur-ozkan
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#128712 (Normalize struct tail properly for
dynptr-to-ptr casting in new solver) - rust-lang#128878 (Slightly refactor
Flagsin bootstrap) - rust-lang#128886 (Get rid of some
#[allow(rustc::untranslatable_diagnostic)]) - rust-lang#128912 (Store
do_not_recommend-ness in impl header) - rust-lang#128936 (Support reading thin archives in ArArchiveBuilder)
- rust-lang#128937 (Fix warnings in rmake tests on
x86_64-unknown-linux-gnu) - rust-lang#128978 (Use
assert_matchesaround the compiler more)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#128712 (Normalize struct tail properly for
dynptr-to-ptr casting in new solver) - rust-lang#128878 (Slightly refactor
Flagsin bootstrap) - rust-lang#128886 (Get rid of some
#[allow(rustc::untranslatable_diagnostic)]) - rust-lang#128912 (Store
do_not_recommend-ness in impl header) - rust-lang#128936 (Support reading thin archives in ArArchiveBuilder)
- rust-lang#128937 (Fix warnings in rmake tests on
x86_64-unknown-linux-gnu) - rust-lang#128978 (Use
assert_matchesaround the compiler more)
r? @ghost
@rustbot modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
Slightly refactor Flags in bootstrap
The next step for rust-lang#126819 is to track commands executed inside Config::parse. This is quite challenging, because (tracked) command execution needs to access some state that is stored inside Config, which creates a sort of a chicken-and-egg problem.
I would like to first untangle Config::parse a little bit, which is what this PR starts with.
Tracking issue: rust-lang#126819
r? @onur-ozkan
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#126245 (Greatly speed up doctests by compiling compatible doctests in one file)
- rust-lang#128394 (Unify run button display with "copy code" button and with mdbook buttons)
- rust-lang#128878 (Slightly refactor
Flagsin bootstrap) - rust-lang#128886 (Get rid of some
#[allow(rustc::untranslatable_diagnostic)]) - rust-lang#128929 (Fix codegen-units tests that were disabled 8 years ago)
- rust-lang#128967 (std::fs::get_path freebsd update.)
- rust-lang#128978 (Use
assert_matchesaround the compiler more)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 10 pull requests
Successful merges:
- rust-lang#128149 (nontemporal_store: make sure that the intrinsic is truly just a hint)
- rust-lang#128394 (Unify run button display with "copy code" button and with mdbook buttons)
- rust-lang#128537 (const vector passed through to codegen)
- rust-lang#128632 (std: do not overwrite style in
get_backtrace_style) - rust-lang#128878 (Slightly refactor
Flagsin bootstrap) - rust-lang#128886 (Get rid of some
#[allow(rustc::untranslatable_diagnostic)]) - rust-lang#128929 (Fix codegen-units tests that were disabled 8 years ago)
- rust-lang#128937 (Fix warnings in rmake tests on
x86_64-unknown-linux-gnu) - rust-lang#128978 (Use
assert_matchesaround the compiler more) - rust-lang#128994 (Fix bug in
Parser::look_ahead.)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#128878 - Kobzol:refactor-flags, r=onur-ozkan
Slightly refactor Flags in bootstrap
The next step for rust-lang#126819 is to track commands executed inside Config::parse. This is quite challenging, because (tracked) command execution needs to access some state that is stored inside Config, which creates a sort of a chicken-and-egg problem.
I would like to first untangle Config::parse a little bit, which is what this PR starts with.
Tracking issue: rust-lang#126819
r? @onur-ozkan
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)