Non-exhaustive structs may be empty by Nadrieril · Pull Request #128934 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This is a follow-up to a discrepancy noticed in #122792: today, the following struct is considered inhabited (non-empty) outside its defining crate:

#[non_exhaustive] pub struct UninhabitedStruct { pub never: !, // other fields }

#[non_exhaustive] on a struct should mean that adding fields to it isn't a breaking change. There is no way that adding fields to this struct could make it non-empty since the never field must stay and is inconstructible. I suspect this was implemented this way due to confusion with #[non_exhaustive] enums, which indeed should be considered non-empty outside their defining crate.

I propose that we consider such a struct uninhabited (empty), just like it would be without the #[non_exhaustive] annotation.

Code that doesn't pass today and will pass after this:

// In a different crate fn empty_match_on_empty_struct(x: UninhabitedStruct) -> T { match x {} }

This is not a breaking change.

r? @compiler-errors

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Aug 10, 2024

This comment has been minimized.

@rfcbot fcp merge

We discussed this in the triage meeting today. This sounded good to us. Let's do it via FCP since there's a one-way door here.

Hey @Nadrieril , I skimmed over the PR and noticed that all the test cases touched here that involve never-typed field also had that same field always marked as pub.

Is there a pre-existing test for the case of a non-exhaustive struct with a non-pub field that is empty? (A situation I infer to be a case which we wish to continue erroring on...)

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

Hey @Nadrieril , I skimmed over the PR and noticed that all the test cases touched here that involve never-typed field also had that same field always marked as pub.

Is there a pre-existing test for the case of a non-exhaustive struct with a non-pub field that is empty? (A situation I infer to be a case which we wish to continue erroring on...)

There isn't a test for non_exaustive + private empty field anymore. You can see that I changed it because I didn't feel it was testing the interesting case (which is non_exhaustive + public empty field, i.e. what the FCP is about).

📌 Commit 6f6a6bc has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 3, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 3, 2024

…, r=compiler-errors

Non-exhaustive structs may be empty

This is a follow-up to a discrepancy noticed in rust-lang#122792: today, the following struct is considered inhabited (non-empty) outside its defining crate:

#[non_exhaustive]
pub struct UninhabitedStruct {
    pub never: !,
    // other fields
}

I propose that we consider such a struct uninhabited (empty), just like it would be without the #[non_exhaustive] annotation.

Code that doesn't pass today and will pass after this:

// In a different crate
fn empty_match_on_empty_struct<T>(x: UninhabitedStruct) -> T {
    match x {}
}

This is not a breaking change.

r? @compiler-errors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 3, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#127692 (Suggest impl Trait for References to Bare Trait in Function Header)
rust-lang#128701 (Don't Suggest Labeling const and unsafe Blocks )
rust-lang#128934 (Non-exhaustive structs may be empty)
rust-lang#129630 (Document the broken C ABI of wasm32-unknown-unknown)
rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
rust-lang#129896 (do not attempt to prove unknowable goals)
rust-lang#129926 (Move SanityCheck and MirPass)
rust-lang#129928 (rustc_driver_impl: remove some old dead logic)
rust-lang#129930 (include 1.80.1 release notes on master)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

Rollup merge of rust-lang#128934 - Nadrieril:fix-empty-non-exhaustive, r=compiler-errors

Non-exhaustive structs may be empty

This is a follow-up to a discrepancy noticed in rust-lang#122792: today, the following struct is considered inhabited (non-empty) outside its defining crate:

#[non_exhaustive]
pub struct UninhabitedStruct {
    pub never: !,
    // other fields
}

I propose that we consider such a struct uninhabited (empty), just like it would be without the #[non_exhaustive] annotation.

Code that doesn't pass today and will pass after this:

// In a different crate
fn empty_match_on_empty_struct<T>(x: UninhabitedStruct) -> T {
    match x {}
}

This is not a breaking change.

r? @compiler-errors

cuviper added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Nov 22, 2024

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Nov 30, 2024

Pkgsrc changes compared to rust182:

Remove patches related to rust-lang/rust#130110, which is now integrated upstream.
Remove patch to vendor/cc-1.0.79, now integrated in the current vendored cc crate.
Checksum updates.

TODO:

Cross-compilation fails ref. rust-lang/rust#133629

Upstream changes:

Version 1.83.0 (2024-11-28)

Language

[Stabilize &mut, *mut, &Cell, and *const Cell in const.] (rust-lang/rust#129195)
[Allow creating references to statics in const initializers.] (rust-lang/rust#129759)
[Implement raw lifetimes and labels ('r#ident).] (rust-lang/rust#126452)
[Define behavior when atomic and non-atomic reads race.] (rust-lang/rust#128778)
[Non-exhaustive structs may now be empty.] (rust-lang/rust#128934)
[Disallow implicit coercions from places of type !] (rust-lang/rust#129392)
[const extern functions can now be defined for other calling conventions.] (rust-lang/rust#129753)
[Stabilize expr_2021 macro fragment specifier in all editions.] (rust-lang/rust#129972)
[The non_local_definitions lint now fires on less code and warns by default.] (rust-lang/rust#127117)

Compiler

[Deprecate unsound -Csoft-float flag.] (rust-lang/rust#129897)
Add many new tier 3 targets:
- [aarch64_unknown_nto_qnx700] (rust-lang/rust#127897)
- [arm64e-apple-tvos] (rust-lang/rust#130614)
- [armv7-rtems-eabihf] (rust-lang/rust#127021)
- [loongarch64-unknown-linux-ohos] (rust-lang/rust#130750)
- [riscv32-wrs-vxworks and riscv64-wrs-vxworks] (rust-lang/rust#130549)
- [riscv32{e|em|emc}-unknown-none-elf] (rust-lang/rust#130555)
- [x86_64-unknown-hurd-gnu] (rust-lang/rust#128345)
- [x86_64-unknown-trusty] (rust-lang/rust#130453)

Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.

Libraries

[Implement PartialEq for ExitCode.] (rust-lang/rust#127633)
[Document that catch_unwind can deal with foreign exceptions without UB, although the exact behavior is unspecified.] (rust-lang/rust#128321)
[Implement Default for HashMap/HashSet iterators that don't already have it.] (rust-lang/rust#128711)
[Bump Unicode to version 16.0.0.] (rust-lang/rust#130183)
[Change documentation of ptr::add/sub to not claim equivalence with offset.] (rust-lang/rust#130229).

Stabilized APIs

[BufRead::skip_until] (https://doc.rust-lang.org/stable/std/io/trait.BufRead.html#method.skip_until)
[ControlFlow::break_value] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.break_value)
[ControlFlow::continue_value] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.continue_value)
[ControlFlow::map_break] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.map_break)
[ControlFlow::map_continue] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.map_continue)
[DebugList::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugList.html#method.finish_non_exhaustive)
[DebugMap::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugMap.html#method.finish_non_exhaustive)
[DebugSet::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugSet.html#method.finish_non_exhaustive)
[DebugTuple::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugTuple.html#method.finish_non_exhaustive)
[ErrorKind::ArgumentListTooLong] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ArgumentListTooLong)
[ErrorKind::Deadlock] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.Deadlock)
[ErrorKind::DirectoryNotEmpty] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.DirectoryNotEmpty)
[ErrorKind::ExecutableFileBusy] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ExecutableFileBusy)
[ErrorKind::FileTooLarge] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.FileTooLarge)
[ErrorKind::HostUnreachable] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.HostUnreachable)
[ErrorKind::IsADirectory] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.IsADirectory)
[ErrorKind::NetworkDown] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NetworkDown)
[ErrorKind::NetworkUnreachable] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NetworkUnreachable)
[ErrorKind::NotADirectory] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NotADirectory)
[ErrorKind::NotSeekable] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NotSeekable)
[ErrorKind::ReadOnlyFilesystem] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ReadOnlyFilesystem)
[ErrorKind::ResourceBusy] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ResourceBusy)
[ErrorKind::StaleNetworkFileHandle] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.StaleNetworkFileHandle)
[ErrorKind::StorageFull] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.StorageFull)
[ErrorKind::TooManyLinks] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.TooManyLinks)
[Option::get_or_insert_default] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.get_or_insert_default)
[Waker::data] (https://doc.rust-lang.org/stable/core/task/struct.Waker.html#method.data)
[Waker::new] (https://doc.rust-lang.org/stable/core/task/struct.Waker.html#method.new)
[Waker::vtable] (https://doc.rust-lang.org/stable/core/task/struct.Waker.html#method.vtable)
[char::MIN] (https://doc.rust-lang.org/stable/core/primitive.char.html#associatedconstant.MIN)
[hash_map::Entry::insert_entry] (https://doc.rust-lang.org/stable/std/collections/hash_map/enum.Entry.html#method.insert_entry)
[hash_map::VacantEntry::insert_entry] (https://doc.rust-lang.org/stable/std/collections/hash_map/struct.VacantEntry.html#method.insert_entry)

These APIs are now stable in const contexts:

[Cell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.Cell.html#method.into_inner)
[Duration::as_secs_f32] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.as_secs_f32)
[Duration::as_secs_f64] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.as_secs_f64)
[Duration::div_duration_f32] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.div_duration_f32)
[Duration::div_duration_f64] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.div_duration_f64)
[MaybeUninit::as_mut_ptr] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.as_mut_ptr)
[NonNull::as_mut] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_mut)
[NonNull::copy_from] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_from)
[NonNull::copy_from_nonoverlapping] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_from_nonoverlapping)
[NonNull::copy_to] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_to)
[NonNull::copy_to_nonoverlapping] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_to_nonoverlapping)
[NonNull::slice_from_raw_parts] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.slice_from_raw_parts)
[NonNull::write] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.write)
[NonNull::write_bytes] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.write_bytes)
[NonNull::write_unaligned] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.write_unaligned)
[OnceCell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.OnceCell.html#method.into_inner)
[Option::as_mut] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_mut)
[Option::expect] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.expect)
[Option::replace] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.replace)
[Option::take] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.take)
[Option::unwrap] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.unwrap)
[Option::unwrap_unchecked] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.unwrap_unchecked)
[Option::<&_>::copied] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.copied)
[Option::<&mut _>::copied] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.copied-1)
[Option::<Option<_>>::flatten] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.flatten)
[Option::<Result<_, _>>::transpose] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.transpose)
[RefCell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.RefCell.html#method.into_inner)
[Result::as_mut] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.as_mut)
[Result::<&_, _>::copied] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.copied)
[Result::<&mut _, _>::copied] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.copied-1)
[Result::<Option<_>, _>::transpose] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.transpose)
[UnsafeCell::get_mut] (https://doc.rust-lang.org/stable/core/cell/struct.UnsafeCell.html#method.get_mut)
[UnsafeCell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.UnsafeCell.html#method.into_inner)
[array::from_mut] (https://doc.rust-lang.org/stable/core/array/fn.from_mut.html)
[char::encode_utf8] (https://doc.rust-lang.org/stable/core/primitive.char.html#method.encode_utf8)
[{float}::classify] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.classify)
[{float}::is_finite] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_finite)
[{float}::is_infinite] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_infinite)
[{float}::is_nan] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_nan)
[{float}::is_normal] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_normal)
[{float}::is_sign_negative] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_sign_negative)
[{float}::is_sign_positive] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_sign_positive)
[{float}::is_subnormal] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_subnormal)
[{float}::from_bits] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_bits)
[{float}::from_be_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_be_bytes)
[{float}::from_le_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_le_bytes)
[{float}::from_ne_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_ne_bytes)
[{float}::to_bits] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_bits)
[{float}::to_be_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_be_bytes)
[{float}::to_le_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_le_bytes)
[{float}::to_ne_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_ne_bytes)
[mem::replace] (https://doc.rust-lang.org/stable/core/mem/fn.replace.html)
[ptr::replace] (https://doc.rust-lang.org/stable/core/ptr/fn.replace.html)
[ptr::slice_from_raw_parts_mut] (https://doc.rust-lang.org/stable/core/ptr/fn.slice_from_raw_parts_mut.html)
[ptr::write] (https://doc.rust-lang.org/stable/core/ptr/fn.write.html)
[ptr::write_unaligned] (https://doc.rust-lang.org/stable/core/ptr/fn.write_unaligned.html)
[<*const _>::copy_to] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to)
[<*const _>::copy_to_nonoverlapping] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to_nonoverlapping)
[<*mut _>::copy_from] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_from)
[<*mut _>::copy_from_nonoverlapping] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_from_nonoverlapping)
[<*mut _>::copy_to] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to-1)
[<*mut _>::copy_to_nonoverlapping] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to_nonoverlapping-1)
[<*mut _>::write] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.write)
[<*mut _>::write_bytes] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.write_bytes)
[<*mut _>::write_unaligned] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.write_unaligned)
[slice::from_mut] (https://doc.rust-lang.org/stable/core/slice/fn.from_mut.html)
[slice::from_raw_parts_mut] (https://doc.rust-lang.org/stable/core/slice/fn.from_raw_parts_mut.html)
[<[_]>::first_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.first_mut)
[<[_]>::last_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.last_mut)
[<[_]>::first_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.first_chunk_mut)
[<[_]>::last_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.last_chunk_mut)
[<[_]>::split_at_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_at_mut)
[<[_]>::split_at_mut_checked] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_at_mut_checked)
[<[_]>::split_at_mut_unchecked] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_at_mut_unchecked)
[<[_]>::split_first_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_first_mut)
[<[_]>::split_last_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_last_mut)
[<[_]>::split_first_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_first_chunk_mut)
[<[_]>::split_last_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_last_chunk_mut)
[str::as_bytes_mut] (https://doc.rust-lang.org/stable/core/primitive.str.html#method.as_bytes_mut)
[str::as_mut_ptr] (https://doc.rust-lang.org/stable/core/primitive.str.html#method.as_mut_ptr)
[str::from_utf8_unchecked_mut] (https://doc.rust-lang.org/stable/core/str/fn.from_utf8_unchecked_mut.html)

Cargo

[Introduced a new CARGO_MANIFEST_PATH environment variable, similar to CARGO_MANIFEST_DIR but pointing directly to the manifest file.] (rust-lang/cargo#14404)
[Added package.autolib to the manifest, allowing [lib] auto-discovery to be disabled.] (rust-lang/cargo#14591)
[Declare support level for each crate in Cargo's Charter / crate docs.] (rust-lang/cargo#14600)
[Declare new Intentional Artifacts as 'small' changes.] (rust-lang/cargo#14599)

Rustdoc

[The sidebar / hamburger menu table of contents now includes the # headers from the main item's doc comment] (rust-lang/rust#120736). This is similar to a third-party feature provided by the rustdoc-search-enhancements browser extension.

Compatibility Notes

[Warn against function pointers using unsupported ABI strings.] (rust-lang/rust#128784)
[Check well-formedness of the source type's signature in fn pointer casts.] (rust-lang/rust#129021) This partly closes a soundness hole that comes when casting a function item to function pointer
[Use equality instead of subtyping when resolving type dependent paths.] (rust-lang/rust#129073)
Linking on macOS now correctly includes Rust's default deployment target. Due to a linker bug, you might have to pass MACOSX_DEPLOYMENT_TARGET or fix your #[link] attributes to point to the correct frameworks. See <rust-lang/rust#129369>.
[Rust will now correctly raise an error for repr(Rust) written on non-struct/enum/union items, since it previous did not have any effect.] (rust-lang/rust#129422)
The future incompatibility lint deprecated_cfg_attr_crate_type_name [has been made into a hard error] (rust-lang/rust#129670). It was used to deny usage of #![crate_type] and #![crate_name] attributes in #![cfg_attr], which required a hack in the compiler to be able to change the used crate type and crate name after cfg expansion. Users can use --crate-type instead of #![cfg_attr(..., crate_type = "...")] and --crate-name instead of #![cfg_attr(..., crate_name = "...")] when running rustc/cargo rustc on the command line. Use of those two attributes outside of #![cfg_attr] continue to be fully supported.
Until now, paths into the sysroot were always prefixed with /rustc/$hash in diagnostics, codegen, backtrace, e.g.
```
thread 'main' panicked at 'hello world', map-panic.rs:2:50
stack backtrace:
   0: std::panicking::begin_panic
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:616:12
   1: map_panic::main::{{closure}}
             at ./map-panic.rs:2:50
   2: core::option::Option<T>::map
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/option.rs:929:29
   3: map_panic::main
             at ./map-panic.rs:2:30
   4: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```
[RFC 3127 said] (https://rust-lang.github.io/rfcs/3127-trim-paths.html#changing-handling-of-sysroot-path-in-rustc)

We want to change this behaviour such that, when rust-src source files can be discovered, the virtual path is discarded and therefore the local path will be embedded, unless there is a --remap-path-prefix that causes this local path to be remapped in the usual way.

#129687 implements this behaviour, when rust-src is present at compile time, rustc replaces /rustc/$hash with a real path into the local rust-src component with best effort. To sanitize this, users must explicitly supply --remap-path-prefix=<path to rust-src>=foo or not have the rust-src component installed.
The allow-by-default missing_docs lint used to disable itself when invoked through rustc --test/cargo test, resulting in #[expect(missing_docs)] emitting false positives due to the expectation being wrongly unfulfilled. This behavior [has now been removed] (rust-lang/rust#130025), which allows #[expect(missing_docs)] to be fulfilled in all scenarios, but will also report new missing_docs diagnostics for publicly reachable #[cfg(test)] items, [integration test] (https://doc.rust-lang.org/cargo/reference/cargo-targets.html#integration-tests) crate-level documentation, and publicly reachable items in integration tests.
[The armv8r-none-eabihf target now uses the Armv8-R required set of floating-point features.] (rust-lang/rust#130295)
[Fix a soundness bug where rustc wouldn't detect unconstrained higher-ranked lifetimes in a dyn Trait's associated types that occur due to supertraits.] (rust-lang/rust#130367)
[Update the minimum external LLVM version to 18.] (rust-lang/rust#130487)
[Remove aarch64-fuchsia and x86_64-fuchsia target aliases in favor of aarch64-unknown-fuchsia and x86_64-unknown-fuchsia respectively.] (rust-lang/rust#130657)
[The ABI-level exception class of a Rust panic is now encoded with native-endian bytes, so it is legible in hex dumps.] (rust-lang/rust#130897)
[Visual Studio 2013 is no longer supported for MSVC targets.] (rust-lang/rust#131070)
[The sysroot no longer contains the std dynamic library in its top-level lib/ dir.] (rust-lang/rust#131188)

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Dec 5, 2024

This MR contains the following updates:

Package	Update	Change
rust	minor	`1.82.0` -> `1.83.0`

MR created with the help of el-capitano/tools/renovate-bot.

Proposed changes to behavior should be submitted there as MRs.

Release Notes

rust-lang/rust (rust)

`v1.83.0`

Compare Source

==========================

Language

Compiler

Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Rustdoc

The sidebar / hamburger menu table of contents now includes the # headers from the main item's doc comment. This is similar to a third-party feature provided by the rustdoc-search-enhancements browser extension.

Compatibility Notes

Warn against function pointers using unsupported ABI strings.
Check well-formedness of the source type's signature in fn pointer casts. This partly closes a soundness hole that comes when casting a function item to function pointer
Use equality instead of subtyping when resolving type dependent paths.
Linking on macOS now correctly includes Rust's default deployment target. Due to a linker bug, you might have to pass MACOSX_DEPLOYMENT_TARGET or fix your #[link] attributes to point to the correct frameworks. See #129369.
Rust will now correctly raise an error for repr(Rust) written on non-struct/enum/union items, since it previous did not have any effect.
The future incompatibility lint deprecated_cfg_attr_crate_type_name has been made into a hard error. It was used to deny usage of #![crate_type] and #![crate_name] attributes in #![cfg_attr], which required a hack in the compiler to be able to change the used crate type and crate name after cfg expansion. Users can use --crate-type instead of #![cfg_attr(..., crate_type = "...")] and --crate-name instead of #![cfg_attr(..., crate_name = "...")] when running rustc/cargo rustc on the command line. Use of those two attributes outside of #![cfg_attr] continue to be fully supported.

Until now, paths into the sysroot were always prefixed with /rustc/$hash in diagnostics, codegen, backtrace, e.g.

thread 'main' panicked at 'hello world', map-panic.rs:2:50
stack backtrace:
   0: std::panicking::begin_panic
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:616:12
   1: map_panic::main::{{closure}}
             at ./map-panic.rs:2:50
   2: core::option::Option<T>::map
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/option.rs:929:29
   3: map_panic::main
             at ./map-panic.rs:2:30
   4: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

RFC 3127 said

We want to change this behaviour such that, when rust-src source files can be discovered, the virtual path is discarded and therefore the local path will be embedded, unless there is a --remap-path-prefix that causes this local path to be remapped in the usual way.

#129687 implements this behaviour, when rust-src is present at compile time, rustc replaces /rustc/$hash with a real path into the local rust-src component with best effort. To sanitize this, users must explicitly supply --remap-path-prefix=<path to rust-src>=foo or not have the rust-src component installed.

The allow-by-default missing_docs lint used to disable itself when invoked through rustc --test/cargo test, resulting in #[expect(missing_docs)] emitting false positives due to the expectation being wrongly unfulfilled. This behavior has now been removed, which allows #[expect(missing_docs)] to be fulfilled in all scenarios, but will also report new missing_docs diagnostics for publicly reachable #[cfg(test)] items, integration test crate-level documentation, and publicly reachable items in integration tests.
The armv8r-none-eabihf target now uses the Armv8-R required set of floating-point features.
Fix a soundness bug where rustc wouldn't detect unconstrained higher-ranked lifetimes in a dyn Trait's associated types that occur due to supertraits.
Update the minimum external LLVM version to 18.
Remove aarch64-fuchsia and x86_64-fuchsia target aliases in favor of aarch64-unknown-fuchsia and x86_64-unknown-fuchsia respectively.
The ABI-level exception class of a Rust panic is now encoded with native-endian bytes, so it is legible in hex dumps.
Visual Studio 2013 is no longer supported for MSVC targets.
The sysroot no longer contains the std dynamic library in its top-level lib/ dir.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

Veykril added a commit to rust-lang/fls that referenced this pull request

Dec 9, 2024

Veykril added a commit to rust-lang/fls that referenced this pull request

Dec 9, 2024

Veykril added a commit to rust-lang/fls that referenced this pull request

Dec 10, 2024

tshepang pushed a commit to ferrocene/ferrocene that referenced this pull request

Dec 18, 2024

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

Feb 24, 2025

Pkgsrc changes:

Introduce use of TOOL* settings.
On NetBSD, use patchelf in the install phase to fix up RPATHs.
Reduce verbosity by dropping -v flag to x.py invocations.
Remove patches related to rust-lang/rust#130110, which is now integrated upstream.
Remove patch to vendor/cc-1.0.79, now integrated in the current vendored cc crate.
Checksum updates.

Upstream changes:

Version 1.83.0 (2024-11-28)

Language

[Stabilize &mut, *mut, &Cell, and *const Cell in const.] (rust-lang/rust#129195)
[Allow creating references to statics in const initializers.] (rust-lang/rust#129759)
[Implement raw lifetimes and labels ('r#ident).] (rust-lang/rust#126452)
[Define behavior when atomic and non-atomic reads race.] (rust-lang/rust#128778)
[Non-exhaustive structs may now be empty.] (rust-lang/rust#128934)
[Disallow implicit coercions from places of type !] (rust-lang/rust#129392)
[const extern functions can now be defined for other calling conventions.] (rust-lang/rust#129753)
[Stabilize expr_2021 macro fragment specifier in all editions.] (rust-lang/rust#129972)
[The non_local_definitions lint now fires on less code and warns by default.] (rust-lang/rust#127117)

Compiler

[Deprecate unsound -Csoft-float flag.] (rust-lang/rust#129897)
Add many new tier 3 targets:
- [aarch64_unknown_nto_qnx700] (rust-lang/rust#127897)
- [arm64e-apple-tvos] (rust-lang/rust#130614)
- [armv7-rtems-eabihf] (rust-lang/rust#127021)
- [loongarch64-unknown-linux-ohos] (rust-lang/rust#130750)
- [riscv32-wrs-vxworks and riscv64-wrs-vxworks] (rust-lang/rust#130549)
- [riscv32{e|em|emc}-unknown-none-elf] (rust-lang/rust#130555)
- [x86_64-unknown-hurd-gnu] (rust-lang/rust#128345)
- [x86_64-unknown-trusty] (rust-lang/rust#130453)

Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.

Libraries

[Implement PartialEq for ExitCode.] (rust-lang/rust#127633)
[Document that catch_unwind can deal with foreign exceptions without UB, although the exact behavior is unspecified.] (rust-lang/rust#128321)
[Implement Default for HashMap/HashSet iterators that don't already have it.] (rust-lang/rust#128711)
[Bump Unicode to version 16.0.0.] (rust-lang/rust#130183)
[Change documentation of ptr::add/sub to not claim equivalence with offset.] (rust-lang/rust#130229).

Stabilized APIs

[BufRead::skip_until] (https://doc.rust-lang.org/stable/std/io/trait.BufRead.html#method.skip_until)
[ControlFlow::break_value] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.break_value)
[ControlFlow::continue_value] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.continue_value)
[ControlFlow::map_break] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.map_break)
[ControlFlow::map_continue] (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.map_continue)
[DebugList::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugList.html#method.finish_non_exhaustive)
[DebugMap::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugMap.html#method.finish_non_exhaustive)
[DebugSet::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugSet.html#method.finish_non_exhaustive)
[DebugTuple::finish_non_exhaustive] (https://doc.rust-lang.org/stable/core/fmt/struct.DebugTuple.html#method.finish_non_exhaustive)
[ErrorKind::ArgumentListTooLong] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ArgumentListTooLong)
[ErrorKind::Deadlock] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.Deadlock)
[ErrorKind::DirectoryNotEmpty] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.DirectoryNotEmpty)
[ErrorKind::ExecutableFileBusy] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ExecutableFileBusy)
[ErrorKind::FileTooLarge] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.FileTooLarge)
[ErrorKind::HostUnreachable] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.HostUnreachable)
[ErrorKind::IsADirectory] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.IsADirectory)
[ErrorKind::NetworkDown] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NetworkDown)
[ErrorKind::NetworkUnreachable] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NetworkUnreachable)
[ErrorKind::NotADirectory] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NotADirectory)
[ErrorKind::NotSeekable] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NotSeekable)
[ErrorKind::ReadOnlyFilesystem] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ReadOnlyFilesystem)
[ErrorKind::ResourceBusy] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ResourceBusy)
[ErrorKind::StaleNetworkFileHandle] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.StaleNetworkFileHandle)
[ErrorKind::StorageFull] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.StorageFull)
[ErrorKind::TooManyLinks] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.TooManyLinks)
[Option::get_or_insert_default] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.get_or_insert_default)
[Waker::data] (https://doc.rust-lang.org/stable/core/task/struct.Waker.html#method.data)
[Waker::new] (https://doc.rust-lang.org/stable/core/task/struct.Waker.html#method.new)
[Waker::vtable] (https://doc.rust-lang.org/stable/core/task/struct.Waker.html#method.vtable)
[char::MIN] (https://doc.rust-lang.org/stable/core/primitive.char.html#associatedconstant.MIN)
[hash_map::Entry::insert_entry] (https://doc.rust-lang.org/stable/std/collections/hash_map/enum.Entry.html#method.insert_entry)
[hash_map::VacantEntry::insert_entry] (https://doc.rust-lang.org/stable/std/collections/hash_map/struct.VacantEntry.html#method.insert_entry)

These APIs are now stable in const contexts:

[Cell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.Cell.html#method.into_inner)
[Duration::as_secs_f32] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.as_secs_f32)
[Duration::as_secs_f64] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.as_secs_f64)
[Duration::div_duration_f32] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.div_duration_f32)
[Duration::div_duration_f64] (https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.div_duration_f64)
[MaybeUninit::as_mut_ptr] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.as_mut_ptr)
[NonNull::as_mut] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_mut)
[NonNull::copy_from] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_from)
[NonNull::copy_from_nonoverlapping] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_from_nonoverlapping)
[NonNull::copy_to] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_to)
[NonNull::copy_to_nonoverlapping] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.copy_to_nonoverlapping)
[NonNull::slice_from_raw_parts] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.slice_from_raw_parts)
[NonNull::write] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.write)
[NonNull::write_bytes] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.write_bytes)
[NonNull::write_unaligned] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.write_unaligned)
[OnceCell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.OnceCell.html#method.into_inner)
[Option::as_mut] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_mut)
[Option::expect] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.expect)
[Option::replace] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.replace)
[Option::take] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.take)
[Option::unwrap] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.unwrap)
[Option::unwrap_unchecked] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.unwrap_unchecked)
[Option::<&_>::copied] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.copied)
[Option::<&mut _>::copied] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.copied-1)
[Option::<Option<_>>::flatten] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.flatten)
[Option::<Result<_, _>>::transpose] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.transpose)
[RefCell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.RefCell.html#method.into_inner)
[Result::as_mut] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.as_mut)
[Result::<&_, _>::copied] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.copied)
[Result::<&mut _, _>::copied] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.copied-1)
[Result::<Option<_>, _>::transpose] (https://doc.rust-lang.org/stable/core/result/enum.Result.html#method.transpose)
[UnsafeCell::get_mut] (https://doc.rust-lang.org/stable/core/cell/struct.UnsafeCell.html#method.get_mut)
[UnsafeCell::into_inner] (https://doc.rust-lang.org/stable/core/cell/struct.UnsafeCell.html#method.into_inner)
[array::from_mut] (https://doc.rust-lang.org/stable/core/array/fn.from_mut.html)
[char::encode_utf8] (https://doc.rust-lang.org/stable/core/primitive.char.html#method.encode_utf8)
[{float}::classify] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.classify)
[{float}::is_finite] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_finite)
[{float}::is_infinite] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_infinite)
[{float}::is_nan] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_nan)
[{float}::is_normal] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_normal)
[{float}::is_sign_negative] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_sign_negative)
[{float}::is_sign_positive] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_sign_positive)
[{float}::is_subnormal] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.is_subnormal)
[{float}::from_bits] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_bits)
[{float}::from_be_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_be_bytes)
[{float}::from_le_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_le_bytes)
[{float}::from_ne_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.from_ne_bytes)
[{float}::to_bits] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_bits)
[{float}::to_be_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_be_bytes)
[{float}::to_le_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_le_bytes)
[{float}::to_ne_bytes] (https://doc.rust-lang.org/stable/core/primitive.f64.html#method.to_ne_bytes)
[mem::replace] (https://doc.rust-lang.org/stable/core/mem/fn.replace.html)
[ptr::replace] (https://doc.rust-lang.org/stable/core/ptr/fn.replace.html)
[ptr::slice_from_raw_parts_mut] (https://doc.rust-lang.org/stable/core/ptr/fn.slice_from_raw_parts_mut.html)
[ptr::write] (https://doc.rust-lang.org/stable/core/ptr/fn.write.html)
[ptr::write_unaligned] (https://doc.rust-lang.org/stable/core/ptr/fn.write_unaligned.html)
[<*const _>::copy_to] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to)
[<*const _>::copy_to_nonoverlapping] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to_nonoverlapping)
[<*mut _>::copy_from] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_from)
[<*mut _>::copy_from_nonoverlapping] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_from_nonoverlapping)
[<*mut _>::copy_to] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to-1)
[<*mut _>::copy_to_nonoverlapping] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.copy_to_nonoverlapping-1)
[<*mut _>::write] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.write)
[<*mut _>::write_bytes] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.write_bytes)
[<*mut _>::write_unaligned] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.write_unaligned)
[slice::from_mut] (https://doc.rust-lang.org/stable/core/slice/fn.from_mut.html)
[slice::from_raw_parts_mut] (https://doc.rust-lang.org/stable/core/slice/fn.from_raw_parts_mut.html)
[<[_]>::first_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.first_mut)
[<[_]>::last_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.last_mut)
[<[_]>::first_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.first_chunk_mut)
[<[_]>::last_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.last_chunk_mut)
[<[_]>::split_at_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_at_mut)
[<[_]>::split_at_mut_checked] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_at_mut_checked)
[<[_]>::split_at_mut_unchecked] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_at_mut_unchecked)
[<[_]>::split_first_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_first_mut)
[<[_]>::split_last_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_last_mut)
[<[_]>::split_first_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_first_chunk_mut)
[<[_]>::split_last_chunk_mut] (https://doc.rust-lang.org/stable/core/primitive.slice.html#method.split_last_chunk_mut)
[str::as_bytes_mut] (https://doc.rust-lang.org/stable/core/primitive.str.html#method.as_bytes_mut)
[str::as_mut_ptr] (https://doc.rust-lang.org/stable/core/primitive.str.html#method.as_mut_ptr)
[str::from_utf8_unchecked_mut] (https://doc.rust-lang.org/stable/core/str/fn.from_utf8_unchecked_mut.html)

Cargo

[Introduced a new CARGO_MANIFEST_PATH environment variable, similar to CARGO_MANIFEST_DIR but pointing directly to the manifest file.] (rust-lang/cargo#14404)
[Added package.autolib to the manifest, allowing [lib] auto-discovery to be disabled.] (rust-lang/cargo#14591)
[Declare support level for each crate in Cargo's Charter / crate docs.] (rust-lang/cargo#14600)
[Declare new Intentional Artifacts as 'small' changes.] (rust-lang/cargo#14599)

Rustdoc

[The sidebar / hamburger menu table of contents now includes the # headers from the main item's doc comment] (rust-lang/rust#120736). This is similar to a third-party feature provided by the rustdoc-search-enhancements browser extension.

Compatibility Notes

[Warn against function pointers using unsupported ABI strings.] (rust-lang/rust#128784)
[Check well-formedness of the source type's signature in fn pointer casts.] (rust-lang/rust#129021) This partly closes a soundness hole that comes when casting a function item to function pointer
[Use equality instead of subtyping when resolving type dependent paths.] (rust-lang/rust#129073)
Linking on macOS now correctly includes Rust's default deployment target. Due to a linker bug, you might have to pass MACOSX_DEPLOYMENT_TARGET or fix your #[link] attributes to point to the correct frameworks. See <rust-lang/rust#129369>.
[Rust will now correctly raise an error for repr(Rust) written on non-struct/enum/union items, since it previous did not have any effect.] (rust-lang/rust#129422)
The future incompatibility lint deprecated_cfg_attr_crate_type_name [has been made into a hard error] (rust-lang/rust#129670). It was used to deny usage of #![crate_type] and #![crate_name] attributes in #![cfg_attr], which required a hack in the compiler to be able to change the used crate type and crate name after cfg expansion. Users can use --crate-type instead of #![cfg_attr(..., crate_type = "...")] and --crate-name instead of #![cfg_attr(..., crate_name = "...")] when running rustc/cargo rustc on the command line. Use of those two attributes outside of #![cfg_attr] continue to be fully supported.
Until now, paths into the sysroot were always prefixed with /rustc/$hash in diagnostics, codegen, backtrace, e.g.
```
thread 'main' panicked at 'hello world', map-panic.rs:2:50
stack backtrace:
   0: std::panicking::begin_panic
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:616:12
   1: map_panic::main::{{closure}}
             at ./map-panic.rs:2:50
   2: core::option::Option<T>::map
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/option.rs:929:29
   3: map_panic::main
             at ./map-panic.rs:2:30
   4: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```
[RFC 3127 said] (https://rust-lang.github.io/rfcs/3127-trim-paths.html#changing-handling-of-sysroot-path-in-rustc)

We want to change this behaviour such that, when rust-src source files can be discovered, the virtual path is discarded and therefore the local path will be embedded, unless there is a --remap-path-prefix that causes this local path to be remapped in the usual way.

#129687 implements this behaviour, when rust-src is present at compile time, rustc replaces /rustc/$hash with a real path into the local rust-src component with best effort. To sanitize this, users must explicitly supply --remap-path-prefix=<path to rust-src>=foo or not have the rust-src component installed.
The allow-by-default missing_docs lint used to disable itself when invoked through rustc --test/cargo test, resulting in #[expect(missing_docs)] emitting false positives due to the expectation being wrongly unfulfilled. This behavior [has now been removed] (rust-lang/rust#130025), which allows #[expect(missing_docs)] to be fulfilled in all scenarios, but will also report new missing_docs diagnostics for publicly reachable #[cfg(test)] items, [integration test] (https://doc.rust-lang.org/cargo/reference/cargo-targets.html#integration-tests) crate-level documentation, and publicly reachable items in integration tests.
[The armv8r-none-eabihf target now uses the Armv8-R required set of floating-point features.] (rust-lang/rust#130295)
[Fix a soundness bug where rustc wouldn't detect unconstrained higher-ranked lifetimes in a dyn Trait's associated types that occur due to supertraits.] (rust-lang/rust#130367)
[Update the minimum external LLVM version to 18.] (rust-lang/rust#130487)
[Remove aarch64-fuchsia and x86_64-fuchsia target aliases in favor of aarch64-unknown-fuchsia and x86_64-unknown-fuchsia respectively.] (rust-lang/rust#130657)
[The ABI-level exception class of a Rust panic is now encoded with native-endian bytes, so it is legible in hex dumps.] (rust-lang/rust#130897)
[Visual Studio 2013 is no longer supported for MSVC targets.] (rust-lang/rust#131070)
[The sysroot no longer contains the std dynamic library in its top-level lib/ dir.] (rust-lang/rust#131188)

Labels

A-exhaustiveness-checking

Relating to exhaustiveness / usefulness checking of patterns

A-patterns

Relating to patterns and pattern matching

disposition-merge

This issue / PR is in PFCP or FCP with a disposition to merge it.

F-non_exhaustive

`#![feature(non_exhaustive)]`

finished-final-comment-period

The final comment period is finished for this PR / Issue.

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-lang

Relevant to the language team, which will review and decide on the PR/issue.