bootstrap: clear miri ui-test deps when miri sysroot gets rebuilt by RalfJung · Pull Request #129000 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Second attempt after #128683: seems like it's not the compiler changing that we care about, but the sysroot changing.

I did some local testing with sysroot rebuilds and it works fine for at least those cases I checked.

r? @onur-ozkan

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Aug 12, 2024

📌 Commit 6839a8f has been approved by onur-ozkan

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 12, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Aug 12, 2024

…nur-ozkan

bootstrap: clear miri ui-test deps when miri sysroot gets rebuilt

Second attempt after rust-lang#128683: seems like it's not the compiler changing that we care about, but the sysroot changing.

I did some local testing with sysroot rebuilds and it works fine for at least those cases I checked.

r? @onur-ozkan

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Aug 12, 2024

…nur-ozkan

bootstrap: clear miri ui-test deps when miri sysroot gets rebuilt

Second attempt after rust-lang#128683: seems like it's not the compiler changing that we care about, but the sysroot changing.

I did some local testing with sysroot rebuilds and it works fine for at least those cases I checked.

r? @onur-ozkan

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 12, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

• rust-lang#128712 (Normalize struct tail properly for dyn ptr-to-ptr casting in new solver)
• rust-lang#128861 (Rework MIR inlining debuginfo so function parameters show up in debuggers.)
• rust-lang#128912 (Store do_not_recommend-ness in impl header)
• rust-lang#129000 (bootstrap: clear miri ui-test deps when miri sysroot gets rebuilt)
• rust-lang#129013 (Remove unused script from run-make tests)
• rust-lang#129017 (Replace std::fmt:FormatterFn with std::fmt::from_fn)

Failed merges:

• rust-lang#128935 (More work on zstd compression)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 12, 2024

…iaskrgr

Rollup of 5 pull requests

Successful merges:

• rust-lang#128712 (Normalize struct tail properly for dyn ptr-to-ptr casting in new solver)
• rust-lang#128912 (Store do_not_recommend-ness in impl header)
• rust-lang#129000 (bootstrap: clear miri ui-test deps when miri sysroot gets rebuilt)
• rust-lang#129013 (Remove unused script from run-make tests)
• rust-lang#129017 (Replace std::fmt:FormatterFn with std::fmt::from_fn)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 13, 2024

Rollup merge of rust-lang#129000 - RalfJung:miri-bootstrap-clear, r=onur-ozkan

bootstrap: clear miri ui-test deps when miri sysroot gets rebuilt

Second attempt after rust-lang#128683: seems like it's not the compiler changing that we care about, but the sysroot changing.

I did some local testing with sysroot rebuilds and it works fine for at least those cases I checked.

r? @onur-ozkan

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)