Print the generic parameter along with the variance in dumps. by cjgillot · Pull Request #129429 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This allows to make sure we are testing what we think we are testing.

While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverse order 💀

📌 Commit 62b29bb has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 22, 2024

This comment has been minimized.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Aug 22, 2024

📌 Commit 6cf0bc0 has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 23, 2024

@bors r- looks like ci failed again

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Aug 23, 2024

This comment has been minimized.

📌 Commit 5cef88c has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 24, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Aug 24, 2024

…r-errors

Print the generic parameter along with the variance in dumps.

This allows to make sure we are testing what we think we are testing.

While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Aug 24, 2024

…r-errors

Print the generic parameter along with the variance in dumps.

This allows to make sure we are testing what we think we are testing.

While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Aug 24, 2024

…r-errors

Print the generic parameter along with the variance in dumps.

This allows to make sure we are testing what we think we are testing.

While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 24, 2024

…kingjubilee

Rollup of 10 pull requests

Successful merges:

• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128467 (Detect * operator on !Sized expression)
• rust-lang#128735 (Add a special case for CStr/CString in the improper_ctypes lint)
• rust-lang#129416 (library: Move unstable API of new_uninit to new features)
• rust-lang#129418 (rustc: Simplify getting sysroot library directory)
• rust-lang#129429 (Print the generic parameter along with the variance in dumps.)
• rust-lang#129430 (rustdoc: show exact case-sensitive matches first)
• rust-lang#129449 (Put Pin::as_deref_mut in impl Pin / rearrange Pin methods)
• rust-lang#129481 (Update compiler_builtins to 0.1.121)
• rust-lang#129482 (Add myself to the review rotation for libs)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Aug 24, 2024

…r-errors

Print the generic parameter along with the variance in dumps.

This allows to make sure we are testing what we think we are testing.

While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 24, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Aug 24, 2024

…r-errors

Print the generic parameter along with the variance in dumps.

This allows to make sure we are testing what we think we are testing.

While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 24, 2024

…iaskrgr

Rollup of 10 pull requests

Successful merges:

• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128467 (Detect * operator on !Sized expression)
• rust-lang#128524 (Don't suggest turning crate-level attributes into outer style)
• rust-lang#128735 (Add a special case for CStr/CString in the improper_ctypes lint)
• rust-lang#129429 (Print the generic parameter along with the variance in dumps.)
• rust-lang#129430 (rustdoc: show exact case-sensitive matches first)
• rust-lang#129449 (Put Pin::as_deref_mut in impl Pin / rearrange Pin methods)
• rust-lang#129481 (Update compiler_builtins to 0.1.121)
• rust-lang#129482 (Add myself to the review rotation for libs)
• rust-lang#129492 (make text more easy to read)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 24, 2024

…iaskrgr

Rollup of 10 pull requests

Successful merges:

• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128467 (Detect * operator on !Sized expression)
• rust-lang#128524 (Don't suggest turning crate-level attributes into outer style)
• rust-lang#128735 (Add a special case for CStr/CString in the improper_ctypes lint)
• rust-lang#129429 (Print the generic parameter along with the variance in dumps.)
• rust-lang#129430 (rustdoc: show exact case-sensitive matches first)
• rust-lang#129449 (Put Pin::as_deref_mut in impl Pin / rearrange Pin methods)
• rust-lang#129481 (Update compiler_builtins to 0.1.121)
• rust-lang#129482 (Add myself to the review rotation for libs)
• rust-lang#129492 (make text more easy to read)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 24, 2024

…iaskrgr

Rollup of 10 pull requests

Successful merges:

• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128467 (Detect * operator on !Sized expression)
• rust-lang#128524 (Don't suggest turning crate-level attributes into outer style)
• rust-lang#128735 (Add a special case for CStr/CString in the improper_ctypes lint)
• rust-lang#129429 (Print the generic parameter along with the variance in dumps.)
• rust-lang#129430 (rustdoc: show exact case-sensitive matches first)
• rust-lang#129449 (Put Pin::as_deref_mut in impl Pin / rearrange Pin methods)
• rust-lang#129481 (Update compiler_builtins to 0.1.121)
• rust-lang#129482 (Add myself to the review rotation for libs)
• rust-lang#129492 (make text more easy to read)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 25, 2024

Rollup of 10 pull requests

Successful merges:

• rust-lang#128467 (Detect * operator on !Sized expression)
• rust-lang#128524 (Don't suggest turning crate-level attributes into outer style)
• rust-lang#128735 (Add a special case for CStr/CString in the improper_ctypes lint)
• rust-lang#129429 (Print the generic parameter along with the variance in dumps.)
• rust-lang#129430 (rustdoc: show exact case-sensitive matches first)
• rust-lang#129449 (Put Pin::as_deref_mut in impl Pin / rearrange Pin methods)
• rust-lang#129481 (Update compiler_builtins to 0.1.121)
• rust-lang#129482 (Add myself to the review rotation for libs)
• rust-lang#129492 (Make wasm32 platform support docs easier to read)
• rust-lang#129512 (update the doc comment on lintchecker b/c it parses html now)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 25, 2024

Rollup of 10 pull requests

Successful merges:

• rust-lang#128467 (Detect * operator on !Sized expression)
• rust-lang#128524 (Don't suggest turning crate-level attributes into outer style)
• rust-lang#128735 (Add a special case for CStr/CString in the improper_ctypes lint)
• rust-lang#129429 (Print the generic parameter along with the variance in dumps.)
• rust-lang#129430 (rustdoc: show exact case-sensitive matches first)
• rust-lang#129449 (Put Pin::as_deref_mut in impl Pin / rearrange Pin methods)
• rust-lang#129481 (Update compiler_builtins to 0.1.121)
• rust-lang#129482 (Add myself to the review rotation for libs)
• rust-lang#129492 (Make wasm32 platform support docs easier to read)
• rust-lang#129512 (update the doc comment on lintchecker b/c it parses html now)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 25, 2024

Rollup merge of rust-lang#129429 - cjgillot:named-variance, r=compiler-errors

Print the generic parameter along with the variance in dumps.

This allows to make sure we are testing what we think we are testing.

While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.