Deny wasm_c_abi lint to nudge the last 25% by workingjubilee · Pull Request #129534 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation14 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

Related:

• Add wasm_c_abi future-incompat lint #117918
• Tracking Issue for perma-unstable wasm-c-abi flag #122532

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering opening a stabilization PR soon, but I think doing this first is a good idea.

📌 Commit af05882 has been approved by daxpedda,me

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 26, 2024

Shouldn't it be r=daxpedda,alexcrichton?

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Aug 26, 2024

@bors: r=daxpedda,alexcrichton

I am clearly a bors pro

📌 Commit af05882 has been approved by daxpedda,alexcrichton

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 26, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Aug 29, 2024

…fcw-to-deny, r=daxpedda,alexcrichton

Deny wasm_c_abi lint to nudge the last 25%

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Aug 29, 2024

…fcw-to-deny, r=daxpedda,alexcrichton

Deny wasm_c_abi lint to nudge the last 25%

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 29, 2024

…kingjubilee

Rollup of 9 pull requests

Successful merges:

• rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
• rust-lang#127912 (std: make thread::current available in all thread_local! destructors)
• rust-lang#128166 (Improved checked_isqrt and isqrt methods)
• rust-lang#129123 (rustdoc-json: Add test for Self type)
• rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
• rust-lang#129527 (Don't use TyKind in a lint)
• rust-lang#129534 (Deny wasm_c_abi lint to nudge the last 25%)
• rust-lang#129640 (Re-enable android tests/benches in alloc/core)
• rust-lang#129675 (allow BufReader::peek to be called on unsized types)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Aug 29, 2024

…fcw-to-deny, r=daxpedda,alexcrichton

Deny wasm_c_abi lint to nudge the last 25%

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 29, 2024

…kingjubilee

Rollup of 8 pull requests

Successful merges:

• rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
• rust-lang#129123 (rustdoc-json: Add test for Self type)
• rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
• rust-lang#129527 (Don't use TyKind in a lint)
• rust-lang#129534 (Deny wasm_c_abi lint to nudge the last 25%)
• rust-lang#129640 (Re-enable android tests/benches in alloc/core)
• rust-lang#129675 (allow BufReader::peek to be called on unsized types)
• rust-lang#129731 (Allow running ./x.py test compiler)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 29, 2024

…kingjubilee

Rollup of 8 pull requests

Successful merges:

• rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
• rust-lang#129123 (rustdoc-json: Add test for Self type)
• rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
• rust-lang#129527 (Don't use TyKind in a lint)
• rust-lang#129534 (Deny wasm_c_abi lint to nudge the last 25%)
• rust-lang#129640 (Re-enable android tests/benches in alloc/core)
• rust-lang#129675 (allow BufReader::peek to be called on unsized types)
• rust-lang#129731 (Allow running ./x.py test compiler)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 29, 2024

…kingjubilee

Rollup of 8 pull requests

Successful merges:

• rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
• rust-lang#129123 (rustdoc-json: Add test for Self type)
• rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
• rust-lang#129527 (Don't use TyKind in a lint)
• rust-lang#129534 (Deny wasm_c_abi lint to nudge the last 25%)
• rust-lang#129640 (Re-enable android tests/benches in alloc/core)
• rust-lang#129675 (allow BufReader::peek to be called on unsized types)
• rust-lang#129731 (Allow running ./x.py test compiler)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 29, 2024

…kingjubilee

Rollup of 8 pull requests

Successful merges:

• rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
• rust-lang#129123 (rustdoc-json: Add test for Self type)
• rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
• rust-lang#129527 (Don't use TyKind in a lint)
• rust-lang#129534 (Deny wasm_c_abi lint to nudge the last 25%)
• rust-lang#129640 (Re-enable android tests/benches in alloc/core)
• rust-lang#129675 (allow BufReader::peek to be called on unsized types)
• rust-lang#129731 (Allow running ./x.py test compiler)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Aug 30, 2024

…fcw-to-deny, r=daxpedda,alexcrichton

Deny wasm_c_abi lint to nudge the last 25%

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 30, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 30, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 30, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Aug 31, 2024

…fcw-to-deny, r=daxpedda,alexcrichton

Deny wasm_c_abi lint to nudge the last 25%

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

This was referenced

Aug 31, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 31, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 31, 2024

Rollup merge of rust-lang#129534 - workingjubilee:ratchet-wasm-c-abi-fcw-to-deny, r=daxpedda,alexcrichton

Deny wasm_c_abi lint to nudge the last 25%

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

Mark-Simulacrum added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Oct 2, 2024

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

IIRC this lint opts out of this by being a "report in deps" FCW, right?

hm. perhaps I misunderstood something then about the interactions here?

...well, at least it doesn't break anyone! 🫠

Isn't the code that has the ABI incompatibility produced by macro expansion of #[wasm_bindgen] inside the user crate? So it would warn for every user of an old version of wasm_bindgen, but be silenced when the user of wasm_bindgen is itself a non-local dependency.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 25, 2025

… r=workingjubilee

Make the wasm_c_abi future compat warning a hard error

This is the next step in getting rid of the broken C abi for wasm32-unknown-unknown.

The lint was made deny-by-default in rust-lang#129534 3 months ago. This still keeps the -Zwasm-c-abi flag set to legacy by default. It will be flipped in a future PR.

cc rust-lang#122532

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 26, 2025

… r=workingjubilee

Make the wasm_c_abi future compat warning a hard error

This is the next step in getting rid of the broken C abi for wasm32-unknown-unknown.

The lint was made deny-by-default in rust-lang#129534 3 months ago. This still keeps the -Zwasm-c-abi flag set to legacy by default. It will be flipped in a future PR.

cc rust-lang#122532

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jan 26, 2025

… r=workingjubilee

Make the wasm_c_abi future compat warning a hard error

This is the next step in getting rid of the broken C abi for wasm32-unknown-unknown.

The lint was made deny-by-default in rust-lang#129534 3 months ago. This still keeps the -Zwasm-c-abi flag set to legacy by default. It will be flipped in a future PR.

cc rust-lang#122532

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 26, 2025

Rollup merge of rust-lang#133951 - bjorn3:wasm_c_abi_lint_hard_error, r=workingjubilee

Make the wasm_c_abi future compat warning a hard error

This is the next step in getting rid of the broken C abi for wasm32-unknown-unknown.

The lint was made deny-by-default in rust-lang#129534 3 months ago. This still keeps the -Zwasm-c-abi flag set to legacy by default. It will be flipped in a future PR.

cc rust-lang#122532

Labels

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.