forward linker option to lint-docs by chenx97 · Pull Request #129957 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This fixes an error found when building the doc for a cross-built toolchain.

warning: the code example in lint `unstable_syntax_pre_expansion` in /buildroots/chenx97/rustc-1.80.1-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `unstable_syntax_p
re_expansion` in output of example, got:

error: linking with `cc` failed: exit status: 1
...

Closes: #129956

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Sep 4, 2024

rustbot added A-cross

Area: Cross compilation

A-linkage

Area: linking into static, shared libraries and binaries

C-bug

Category: This is a bug.

labels

Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR!
@bors r+ rollup

📌 Commit 4df28b8 has been approved by albertlarsan68

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 4, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

…bertlarsan68

forward linker option to lint-docs

This fixes an error found when building the doc for a cross-built toolchain.

warning: the code example in lint `unstable_syntax_pre_expansion` in /buildroots/chenx97/rustc-1.80.1-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `unstable_syntax_p
re_expansion` in output of example, got:

error: linking with `cc` failed: exit status: 1
...

Closes: rust-lang#129956

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

…bertlarsan68

forward linker option to lint-docs

This fixes an error found when building the doc for a cross-built toolchain.

warning: the code example in lint `unstable_syntax_pre_expansion` in /buildroots/chenx97/rustc-1.80.1-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `unstable_syntax_p
re_expansion` in output of example, got:

error: linking with `cc` failed: exit status: 1
...

Closes: rust-lang#129956

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

…bertlarsan68

forward linker option to lint-docs

This fixes an error found when building the doc for a cross-built toolchain.

warning: the code example in lint `unstable_syntax_pre_expansion` in /buildroots/chenx97/rustc-1.80.1-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `unstable_syntax_p
re_expansion` in output of example, got:

error: linking with `cc` failed: exit status: 1
...

Closes: rust-lang#129956

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 12 pull requests

Successful merges:

• rust-lang#128919 (Add an internal lint that warns when accessing untracked data)
• rust-lang#129472 (fix ICE when asm_const and const_refs_to_static are combined)
• rust-lang#129653 (clarify that addr_of creates read-only pointers)
• rust-lang#129775 (bootstrap: Try to track down why initial_libdir sometimes fails)
• rust-lang#129939 (explain why Rvalue::Len still exists)
• rust-lang#129940 (s390x: Fix a regression related to backchain feature)
• rust-lang#129942 (copy rustc rustlib artifacts from ci-rustc)
• rust-lang#129943 (use the bootstrapped compiler for test-float-parse test)
• rust-lang#129944 (Add compat note for trait solver change)
• rust-lang#129947 (Add digit separators in Duration examples)
• rust-lang#129955 (Temporarily remove fmease from the review rotation)
• rust-lang#129957 (forward linker option to lint-docs)

Failed merges:

• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 12 pull requests

Successful merges:

• rust-lang#128919 (Add an internal lint that warns when accessing untracked data)
• rust-lang#129472 (fix ICE when asm_const and const_refs_to_static are combined)
• rust-lang#129653 (clarify that addr_of creates read-only pointers)
• rust-lang#129775 (bootstrap: Try to track down why initial_libdir sometimes fails)
• rust-lang#129939 (explain why Rvalue::Len still exists)
• rust-lang#129940 (s390x: Fix a regression related to backchain feature)
• rust-lang#129942 (copy rustc rustlib artifacts from ci-rustc)
• rust-lang#129943 (use the bootstrapped compiler for test-float-parse test)
• rust-lang#129944 (Add compat note for trait solver change)
• rust-lang#129947 (Add digit separators in Duration examples)
• rust-lang#129955 (Temporarily remove fmease from the review rotation)
• rust-lang#129957 (forward linker option to lint-docs)

Failed merges:

• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 12 pull requests

Successful merges:

• rust-lang#128919 (Add an internal lint that warns when accessing untracked data)
• rust-lang#129472 (fix ICE when asm_const and const_refs_to_static are combined)
• rust-lang#129653 (clarify that addr_of creates read-only pointers)
• rust-lang#129775 (bootstrap: Try to track down why initial_libdir sometimes fails)
• rust-lang#129939 (explain why Rvalue::Len still exists)
• rust-lang#129940 (s390x: Fix a regression related to backchain feature)
• rust-lang#129942 (copy rustc rustlib artifacts from ci-rustc)
• rust-lang#129943 (use the bootstrapped compiler for test-float-parse test)
• rust-lang#129944 (Add compat note for trait solver change)
• rust-lang#129947 (Add digit separators in Duration examples)
• rust-lang#129955 (Temporarily remove fmease from the review rotation)
• rust-lang#129957 (forward linker option to lint-docs)

Failed merges:

• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 6, 2024

…bertlarsan68

forward linker option to lint-docs

This fixes an error found when building the doc for a cross-built toolchain.

warning: the code example in lint `unstable_syntax_pre_expansion` in /buildroots/chenx97/rustc-1.80.1-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `unstable_syntax_p
re_expansion` in output of example, got:

error: linking with `cc` failed: exit status: 1
...

Closes: rust-lang#129956

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 6, 2024

…bertlarsan68

forward linker option to lint-docs

This fixes an error found when building the doc for a cross-built toolchain.

warning: the code example in lint `unstable_syntax_pre_expansion` in /buildroots/chenx97/rustc-1.80.1-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `unstable_syntax_p
re_expansion` in output of example, got:

error: linking with `cc` failed: exit status: 1
...

Closes: rust-lang#129956

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 6, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 6, 2024

Rollup merge of rust-lang#129957 - chenx97:lint-docs-linker-opt, r=albertlarsan68

forward linker option to lint-docs

This fixes an error found when building the doc for a cross-built toolchain.

warning: the code example in lint `unstable_syntax_pre_expansion` in /buildroots/chenx97/rustc-1.80.1-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `unstable_syntax_p
re_expansion` in output of example, got:

error: linking with `cc` failed: exit status: 1
...

Closes: rust-lang#129956

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 6, 2024

chenx97 deleted the lint-docs-linker-opt branch

October 28, 2024 19:07

Labels

A-cross

Area: Cross compilation

A-linkage

Area: linking into static, shared libraries and binaries

C-bug

Category: This is a bug.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)