Stabilize const MaybeUninit::as_mut_ptr by ultrabear · Pull Request #130542 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ultrabear

This PR stabilizes the following APIs as const stable as of rust 1.83:

impl MaybeUninit { pub const fn as_mut_ptr(&mut self) -> *mut T; }

This is made possible by const_mut_refs being stabilized (yay).

FCP: #75251 (comment)

@ultrabear

@ultrabear

@rustbot

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Sep 19, 2024

@rust-log-analyzer

This comment has been minimized.

@ultrabear

@workingjubilee

New API, as noted libs-api has decided this one doesn't need a new FCP.

@rustbot label: relnotes

@bors r+

@bors

📌 Commit b7ca2b6 has been approved by workingjubilee

It is now in the queue for this repository.

@rustbot rustbot added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Sep 19, 2024

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 19, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 19, 2024

@workingjubilee

…nit_as_mut_ptr, r=workingjubilee

Stabilize const MaybeUninit::as_mut_ptr

This PR stabilizes the following APIs as const stable as of rust 1.83:

impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}

This is made possible by const_mut_refs being stabilized (yay).

FCP: rust-lang#75251 [(comment)](rust-lang#75251 (comment))

This was referenced

Sep 19, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 19, 2024

@bors

…kingjubilee

Rollup of 3 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 19, 2024

@rust-timer

Rollup merge of rust-lang#130542 - ultrabear:stabilize_const_maybeuninit_as_mut_ptr, r=workingjubilee

Stabilize const MaybeUninit::as_mut_ptr

This PR stabilizes the following APIs as const stable as of rust 1.83:

impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}

This is made possible by const_mut_refs being stabilized (yay).

FCP: rust-lang#75251 [(comment)](rust-lang#75251 (comment))

@ojeda ojeda mentioned this pull request

Nov 25, 2024

95 tasks

Labels

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.