add TestFloatParse to tools.rs for bootstrap by lucarlig · Pull Request #131731 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation29 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
add TestFloatParse to tools for bootstrap, I am not sure this is what the issue #128012 discussion wants.
try-job: aarch64-apple
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
@tgross35 could you elaborate what you want for test-float-parse again?
Marking this as blocked waiting for @tgross35 to help me understand what is the desired changes.
@rustbot blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
For test-float-parse specifically I think I wanted a build step so ./x build test-float-parse works. It seems like this is what is here. The more general thing is that to me it seems like prepare_tool_cargo should just call builder.ensure to compile std, since it seemed like anything that calls prepare_tool_cargo needs to call builder.ensure anyway.
I honestly don't remember the exact change that I was planning to do and forgot. @onur-ozkan do you know what change we should do based on #128012?
I will review this once I get some free time.
r? onur-ozkan
Status: Awaiting review from the assignee but also interested parties.
and removed S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
labels
For
test-float-parsespecifically I think I wanted a build step so./x build test-float-parseworks. It seems like this is what is here. The more general thing is that to me it seems likeprepare_tool_cargoshould just callbuilder.ensureto compile std, since it seemed like anything that callsprepare_tool_cargoneeds to callbuilder.ensureanyway.I honestly don't remember the exact change that I was planning to do and forgot. @onur-ozkan do you know what change we should do based on #128012?
I think that would require passing the Step directly to prepare_too_cargo also I noticed that too many args are present on it, the solution could be to pass the CargoCommand directly instead of all the parameters, what else is required from CargoCommand can be derived inside the prepare_too_cargo.
Some changes occurred in src/tools/cargo
cc @ehuss
Some changes occurred in src/tools/cargo
cc @ehuss
removed those
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last notes:
bors added a commit to rust-lang-ci/rust that referenced this pull request
add TestFloatParse to tools.rs for bootstrap
add TestFloatParse to tools for bootstrap, I am not sure this is what the issue rust-lang#128012 discussion wants.
try-job: aarch64-apple
☀️ Try build successful - checks-actions
Build commit: 727ce5b (727ce5bd6982a133701fa5dc646615745a846aba)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Could you please squash your commits?
LGTM - Could you please squash your commits?
done @onur-ozkan
📌 Commit bc9fc71 has been approved by onur-ozkan
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#125205 (Fixup Windows verbatim paths when used with the
include!macro) - rust-lang#131049 (Validate args are correct for
UnevaluatedConst,ExistentialTraitRef/ExistentialProjection) - rust-lang#131549 (Add a note for
?on aimpl Future<Output = Result<..>>in sync function) - rust-lang#131731 (add
TestFloatParsetotools.rsfor bootstrap) - rust-lang#131732 (Add doc(plugins), doc(passes), etc. to INVALID_DOC_ATTRIBUTES)
- rust-lang#132006 (don't stage-off to previous compiler when CI rustc is available)
- rust-lang#132022 (Move
cmp_in_dominator_orderout of graph dominator computation) - rust-lang#132033 (compiletest: Make
line_directivereturn aDirectiveLine)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#131731 - lucarlig:master, r=onur-ozkan
add TestFloatParse to tools.rs for bootstrap
add TestFloatParse to tools for bootstrap, I am not sure this is what the issue rust-lang#128012 discussion wants.
try-job: aarch64-apple
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)