rustdoc: Switch from FxHash to sha256 for static file hashing. by aDotInTheVoid · Pull Request #131908 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #129533 (comment)
fxhash isn't well defined, and it's implementation is being changed in #129533. But because rustdoc uses it for static files (and encodes that hashing in rustdoc.css), this broke our tests. Given that this isn't performace critical, I think the right fix is to used a well-defined hash that will never change its definition. I've picked (rather arbitrarily) sha256.
rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.
Some changes occurred in HTML/CSS/JS.
cc @GuillaumeGomez, @jsha
This comment has been minimized.
Just realised the same thing a few seconds ago. Thanks a lot!
r=me once CI pass
@bors r=notriddle,GuillaumeGomez
📌 Commit 3cf8a61 has been approved by notriddle,GuillaumeGomez
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…g, r=notriddle,GuillaumeGomez
rustdoc: Switch from FxHash to sha256 for static file hashing.
Fixes rust-lang#129533 (comment)
fxhash isn't well defined, and it's implementation is being changed in rust-lang#129533. But because rustdoc uses it for static files (and encodes that hashing in rustdoc.css), this broke our tests. Given that this isn't performace critical, I think the right fix is to used a well-defined hash that will never change its definition. I've picked (rather arbitrarily) sha256.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 8 pull requests
Successful merges:
- rust-lang#127462 (std: uefi: Add basic Env variables)
- rust-lang#131537 (Fix range misleading field access)
- rust-lang#131838 (bootstrap: allow setting
--jobsin config.toml) - rust-lang#131871 (x86-32 float return for 'Rust' ABI: treat all float types consistently)
- rust-lang#131876 (compiler: Use LLVM's Comdat support)
- rust-lang#131890 (Update
usekeyword docs to describe precise capturing) - rust-lang#131899 (Mark unexpected variant res suggestion as having placeholders)
- rust-lang#131908 (rustdoc: Switch from FxHash to sha256 for static file hashing.)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…g, r=notriddle,GuillaumeGomez
rustdoc: Switch from FxHash to sha256 for static file hashing.
Fixes rust-lang#129533 (comment)
fxhash isn't well defined, and it's implementation is being changed in rust-lang#129533. But because rustdoc uses it for static files (and encodes that hashing in rustdoc.css), this broke our tests. Given that this isn't performace critical, I think the right fix is to used a well-defined hash that will never change its definition. I've picked (rather arbitrarily) sha256.
bors added a commit to rust-lang-ci/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…g, r=notriddle,GuillaumeGomez
rustdoc: Switch from FxHash to sha256 for static file hashing.
Fixes rust-lang#129533 (comment)
fxhash isn't well defined, and it's implementation is being changed in rust-lang#129533. But because rustdoc uses it for static files (and encodes that hashing in rustdoc.css), this broke our tests. Given that this isn't performace critical, I think the right fix is to used a well-defined hash that will never change its definition. I've picked (rather arbitrarily) sha256.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#127462 (std: uefi: Add basic Env variables)
- rust-lang#131537 (Fix range misleading field access)
- rust-lang#131838 (bootstrap: allow setting
--jobsin config.toml) - rust-lang#131871 (x86-32 float return for 'Rust' ABI: treat all float types consistently)
- rust-lang#131890 (Update
usekeyword docs to describe precise capturing) - rust-lang#131899 (Mark unexpected variant res suggestion as having placeholders)
- rust-lang#131908 (rustdoc: Switch from FxHash to sha256 for static file hashing.)
- rust-lang#131916 (small interpreter error cleanup)
- rust-lang#131919 (zero-sized accesses are fine on null pointers)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#127462 (std: uefi: Add basic Env variables)
- rust-lang#131537 (Fix range misleading field access)
- rust-lang#131838 (bootstrap: allow setting
--jobsin config.toml) - rust-lang#131890 (Update
usekeyword docs to describe precise capturing) - rust-lang#131899 (Mark unexpected variant res suggestion as having placeholders)
- rust-lang#131908 (rustdoc: Switch from FxHash to sha256 for static file hashing.)
- rust-lang#131916 (small interpreter error cleanup)
- rust-lang#131919 (zero-sized accesses are fine on null pointers)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#131908 - aDotInTheVoid:rustdoc-gamer-hashing, r=notriddle,GuillaumeGomez
rustdoc: Switch from FxHash to sha256 for static file hashing.
Fixes rust-lang#129533 (comment)
fxhash isn't well defined, and it's implementation is being changed in rust-lang#129533. But because rustdoc uses it for static files (and encodes that hashing in rustdoc.css), this broke our tests. Given that this isn't performace critical, I think the right fix is to used a well-defined hash that will never change its definition. I've picked (rather arbitrarily) sha256.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the rustdoc team, which will review and decide on the PR/issue.