Derive Copy and Hash for IntErrorKind by ranger-ross · Pull Request #131923 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This PR derives Copy and Hash for IntErrorKind to make it easier to work with. (see #131826)
I think an argument could be made to also derive PartialOrd + Ord as well given that other error kinds in the std like io::ErrorKind do this. Granted these seem much less useful for errors.
Fixes #131826
r? @joboet
rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Makes sense to me, but this will need FCP.
r? libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
label
This change is insta-stable, so needs a completed FCP to proceed.
label
This is a pretty easy change, nominating to get it on the radar.
@rustbot label +I-libs-api-nominated
Relevant to the library team, which will review and decide on the PR/issue.
label
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
🔔 This is now entering its final comment period, as per the review above. 🔔
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
Labels
This issue / PR is in PFCP or FCP with a disposition to merge it.
The final comment period is finished for this PR / Issue.
Libs issues that are considered "small" or self-contained
This change is insta-stable, so needs a completed FCP to proceed.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library API team, which will review and decide on the PR/issue.