CI: rfl: use rust-next temporary commit by adetaylor · Pull Request #132058 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation15 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Commit c95bbb59a9b22f9b838b15d28319185c1c884329 within rust-next contains some changes required to be compatible with upcoming arbitraty self types work. Roll RFL CI forward to the latest rust-next to include that work.

Related:
#130225
#44874

r? @ojeda

try-job: x86_64-rust-for-linux

Failed to set assignee to ojeda: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot added A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-infra

Relevant to the infrastructure team, which will review and decide on the PR/issue.

labels

Oct 23, 2024

Looks good to me, thanks!

(We could do this also in the other PR that needs it, but if it can be done independently first, even better.)

Let's give it a try run.

r? @lqd
r? @Kobzol

try-job: x86_64-rust-for-linux
@bors try

@rustbot label A-rust-for-linux

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 23, 2024

CI: rfl: use rust-next temporary commit

r? @ojeda

ojeda mentioned this pull request

Oct 23, 2024

15 tasks

Member

lqd commented

Oct 23, 2024

• Loading

@ojeda you need try-job: x86_64-rust-for-linux in the PR description for this to work. Otherwise, it will use the default x64 linux dist build.

I added it, @bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 23, 2024

CI: rfl: use rust-next temporary commit

r? @ojeda

try-job: x86_64-rust-for-linux

✌️ @ojeda, you can now approve this pull request!

If @lqd told you to "r=me" after making some further change, please make that change, then do @bors r=@lqd

@ojeda you need try-job: x86_64-rust-for-linux in the PR description for this to work. Otherwise, it will use the default x64 linux dist build.

I added it, @bors try

Thanks! I was hoping it would pick it up in the entire thread like the other bots.

I don't have permission to edit PR descriptions, I think.

☀️ Try build successful - checks-actions
Build commit: f2f1c92 (f2f1c92b06cb588926fbfe26d8bce97ab2acf897)

@adetaylor: 🔑 Insufficient privileges: Not in reviewers

📌 Commit 2eb7e0d has been approved by lqd

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 23, 2024

I was hoping it would pick it up in the entire thread like the other bots.

Not yet unfortunately. Any improvements there will need the bors rewrite (for example try=some_job), the current codebase is incredibly hard to change reliably without regressions, and this was the best we could do until then.

I see, thanks! I think you have a quite nice overall system regardless :)

fmease added a commit to fmease/rust that referenced this pull request

Oct 23, 2024