cg_llvm: Consistently use safe wrapper function set_section by Zalathar · Pull Request #132340 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Follow-up to #131962 and #132260 (comment).
To avoid too much scope creep, I've deliberately kept the changes to LLVMRustGetSliceFromObjectDataByName as minimal as possible.
r? @lcnr
rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit 65ff2a6 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…rrors
cg_llvm: Consistently use safe wrapper function set_section
Follow-up to rust-lang#131962 and rust-lang#132260 (comment).
To avoid too much scope creep, I've deliberately kept the changes to LLVMRustGetSliceFromObjectDataByName as minimal as possible.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 8 pull requests
Successful merges:
- rust-lang#129394 (Don't lint
irrefutable_let_patternson leading patterns ifelse iflet-chains) - rust-lang#131856 (TypingMode: merge intercrate, reveal, and defining_opaque_types)
- rust-lang#132246 (Rename
rustc_abi::AbitoBackendRepr) - rust-lang#132322 (powerpc64-ibm-aix: update maintainters)
- rust-lang#132327 (Point to Fuchsia team in platform support docs)
- rust-lang#132332 (Use
token_descrmore in error messages) - rust-lang#132338 (Remove
Engine) - rust-lang#132340 (cg_llvm: Consistently use safe wrapper function
set_section)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#129394 (Don't lint
irrefutable_let_patternson leading patterns ifelse iflet-chains) - rust-lang#131856 (TypingMode: merge intercrate, reveal, and defining_opaque_types)
- rust-lang#132322 (powerpc64-ibm-aix: update maintainters)
- rust-lang#132327 (Point to Fuchsia team in platform support docs)
- rust-lang#132332 (Use
token_descrmore in error messages) - rust-lang#132338 (Remove
Engine) - rust-lang#132340 (cg_llvm: Consistently use safe wrapper function
set_section) - rust-lang#132342 (cg_llvm: Clean up FFI calls for operand bundles)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#132340 - Zalathar:set-section, r=compiler-errors
cg_llvm: Consistently use safe wrapper function set_section
Follow-up to rust-lang#131962 and rust-lang#132260 (comment).
To avoid too much scope creep, I've deliberately kept the changes to LLVMRustGetSliceFromObjectDataByName as minimal as possible.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.