macOS: Document the difference between Clang's -darwin and -macosx targets by madsmtm · Pull Request #132417 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
rustc's *-apple-darwin targets are badly named (they should've been called *-apple-macos), and this causes confusion wrt. the similarly named but somewhat incompatible Clang targets.
So let's document the difference to at least make things a little easier on our users.
@rustbot label O-macos A-docs
r? @ehuss
rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Some changes occurred in src/doc/rustc/src/platform-support
cc @Noratrieb
Operating system: macOS
Area: Documentation for any part of the project, including the compiler, standard library, and tools
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
r? jieyouxu
@bors r+ rollup
📌 Commit 40f4b21 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…erence, r=jieyouxu
macOS: Document the difference between Clang's -darwin and -macosx targets
rustc's *-apple-darwin targets are badly named (they should've been called *-apple-macos), and this causes confusion wrt. the similarly named but somewhat incompatible Clang targets.
So let's document the difference to at least make things a little easier on our users.
@rustbot label O-macos A-docs
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#131168 (Fix
target_osformipsel-sony-psx) - rust-lang#132209 (Fix validation when lowering
?trait bounds) - rust-lang#132357 (Improve missing_abi lint)
- rust-lang#132385 (compiler: Move
rustc_target::spec::abi::Abitorustc_abi::ExternAbi) - rust-lang#132417 (macOS: Document the difference between Clang's
-darwinand-macosxtargets)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#132417 - madsmtm:document-darwin-macos-difference, r=jieyouxu
macOS: Document the difference between Clang's -darwin and -macosx targets
rustc's *-apple-darwin targets are badly named (they should've been called *-apple-macos), and this causes confusion wrt. the similarly named but somewhat incompatible Clang targets.
So let's document the difference to at least make things a little easier on our users.
@rustbot label O-macos A-docs
Labels
Area: Documentation for any part of the project, including the compiler, standard library, and tools
Operating system: macOS
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.