Don't exclude relnotes from needs-triage label by jieyouxu · Pull Request #133283 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
So initially we didn't exclude needs-triage label, then we did exclude them in #132825 as sometimes the needs-triage is redundant. However, I think they are probably worth double-checking because often some of the labels are only accurate/relevant for the implementation PR, but not for the purposes of the relnotes tracking issue. Furthermore, sometimes relevant team labels can be removed. So to make it less likely for relnotes to slip through, I think we should still label relnotes-tracking-issues with needs-triage.
cc https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang
r? release
Area: Issues & PRs about the rust-lang/rust repository itself
Status: Awaiting review from the assignee but also interested parties.
labels
triagebot.toml has been modified, there may have been changes to the review queue.
📌 Commit 61a03fa has been approved by BoxyUwU
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
👍 I personnaly think needs-triage is also useful as a proxy to know if the relnote for that PR/issue have been looked at, independently of the labels.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
Don't exclude relnotes from needs-triage label
So initially we didn't exclude needs-triage label, then we did exclude them in rust-lang#132825 as sometimes the needs-triage is redundant. However, I think they are probably worth double-checking because often some of the labels are only accurate/relevant for the implementation PR, but not for the purposes of the relnotes tracking issue. Furthermore, sometimes relevant team labels can be removed. So to make it less likely for relnotes to slip through, I think we should still label relnotes-tracking-issues with needs-triage.
cc https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang
r? release
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#130236 (unstable feature usage metrics)
- rust-lang#131544 (Make asm label blocks safe context)
- rust-lang#131586 (Support s390x z13 vector ABI)
- rust-lang#132489 (Fix closure arg extraction in
extract_callable_info, generalize it to async closures) - rust-lang#133078 (tests: ui/inline-consts: add issue number to a test, rename other tests)
- rust-lang#133283 (Don't exclude relnotes from
needs-triagelabel)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#133283 - jieyouxu:triage-relnotes, r=BoxyUwU
Don't exclude relnotes from needs-triage label
So initially we didn't exclude needs-triage label, then we did exclude them in rust-lang#132825 as sometimes the needs-triage is redundant. However, I think they are probably worth double-checking because often some of the labels are only accurate/relevant for the implementation PR, but not for the purposes of the relnotes tracking issue. Furthermore, sometimes relevant team labels can be removed. So to make it less likely for relnotes to slip through, I think we should still label relnotes-tracking-issues with needs-triage.
cc https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang
r? release
Labels
Area: Issues & PRs about the rust-lang/rust repository itself
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.