Use eprintln instead of println in bootstrap/compiletest/tidy by clubby789 · Pull Request #133817 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits3 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
A big unconditional CTRL-F replace to start with to check if there's anything that CI expects to be on stdout
r? @jieyouxu
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I left some suggestions.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Thanks! As usual, the only way to find out if any of these turns out somehow load-bearing is to merge it.
@bors r+ rollup
📌 Commit 8374f7c has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#133651 (Update
NonZeroandNonNullto not field-project (per MCP#807)) - rust-lang#133764 (rustdoc: Rename
set_back_infotorestore_module_data.) - rust-lang#133784 (Fix MutVisitor's default implementations to visit Stmt's and BinOp's spans)
- rust-lang#133798 (stop replacing bivariant args with
'staticwhen computing closure requirements) - rust-lang#133804 (Improve code for FileName retrieval in rustdoc)
- rust-lang#133817 (Use
eprintlninstead ofprintlnin bootstrap/compiletest/tidy)
Failed merges:
- rust-lang#133810 (remove unnecessary
eval_verify_bound)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#133817 - clubby789:bootstrap-eprintln, r=jieyouxu
Use eprintln instead of println in bootstrap/compiletest/tidy
A big unconditional CTRL-F replace to start with to check if there's anything that CI expects to be on stdout
r? @jieyouxu
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…ln, r=jieyouxu"
This reverts commit 0585134, reversing changes made to 5530869.
The PR unfortunately only converted the ln! instances, meaning that
test output was messed up because stdout/stderr output interleaved when
some println! instances were converted to eprintln! instances, while
some println! instances remain unchanged.
Zalathar added a commit to Zalathar/rust that referenced this pull request
…ln, r=jieyouxu"
This reverts commit 0585134, reversing changes made to 5530869.
fmease added a commit to fmease/rust that referenced this pull request
Revert rust-lang#133817
This reverts commit 0585134, reversing changes made to 5530869.
rust-lang#133817 unfortunately only converted the println! instances to eprintln!, meaning that some test output (via compiletest/bootstrap) was messed up because stdout/stderr output interleaved improperly when some println! instances were converted to eprintln! instances, while some print! instances remain unchanged. This made reading test output annoying for contributors cc rust-lang#133879.
Closes rust-lang#133879 by reverting.
rust-lang#133817 can be relanded in the future when print! instances are also matched with println! instances.
cc @clubby789
This is a clean revert so I'm going to self-approve this PR.
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#133892 - jieyouxu:revert-eprintln, r=jieyouxu
Revert rust-lang#133817
This reverts commit 0585134, reversing changes made to 5530869.
rust-lang#133817 unfortunately only converted the println! instances to eprintln!, meaning that some test output (via compiletest/bootstrap) was messed up because stdout/stderr output interleaved improperly when some println! instances were converted to eprintln! instances, while some print! instances remain unchanged. This made reading test output annoying for contributors cc rust-lang#133879.
Closes rust-lang#133879 by reverting.
rust-lang#133817 can be relanded in the future when print! instances are also matched with println! instances.
cc @clubby789
This is a clean revert so I'm going to self-approve this PR.
fmease added a commit to fmease/rust that referenced this pull request
…eyouxu
bootstrap: print{ln}! -> eprint{ln}! (take 2)
r? @jieyouxu
Reland of rust-lang#133817 with the print!s changed as well.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#134040 - clubby789:bootstrap-eprintln, r=jieyouxu
bootstrap: print{ln}! -> eprint{ln}! (take 2)
r? @jieyouxu
Reland of rust-lang#133817 with the print!s changed as well.
Labels
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)