fix ICE on type error in promoted by RalfJung · Pull Request #134010 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #133968
Ensure that when we turn a type error into a "this promoted failed to evaluate" error, we do record this as something that may happen even in "infallible" promoteds.
r? @pnkfelix
rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Some changes occurred to the CTFE machinery
cc @rust-lang/wg-const-eval
Some changes occurred to the CTFE / Miri interpreter
cc @rust-lang/miri
Some changes occurred to the CTFE / Miri interpreter
cc @rust-lang/miri, @rust-lang/wg-const-eval
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a const fails to typecheck, we no longer point at where that const is used... IMO that is an improvement, since the typecheck error doesn't really depend on usage.
This comment has been minimized.
Some changes occurred in src/tools/clippy
cc @rust-lang/clippy
This comment has been minimized.
This comment has been minimized.
r? @oli-obk
@bors r=oli-obk
(Hoping I interpreted your GH approval correctly.)
📌 Commit ed8ee39 has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
fmease added a commit to fmease/rust that referenced this pull request
…r=oli-obk
fix ICE on type error in promoted
Fixes rust-lang#133968
Ensure that when we turn a type error into a "this promoted failed to evaluate" error, we do record this as something that may happen even in "infallible" promoteds.
fmease added a commit to fmease/rust that referenced this pull request
…r=oli-obk
fix ICE on type error in promoted
Fixes rust-lang#133968
Ensure that when we turn a type error into a "this promoted failed to evaluate" error, we do record this as something that may happen even in "infallible" promoteds.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- rust-lang#131558 (Lint on combining
#[no_mangle]and#[export_name]) - rust-lang#133122 (Add unpolished, experimental support for AFIDT (async fn in dyn trait))
- rust-lang#133184 (wasi/fs: Improve stopping condition for ::next)
- rust-lang#133456 (Add licenses + Run
cargo update) - rust-lang#133472 (Run TLS destructors for wasm32-wasip1-threads)
- rust-lang#133853 (use vendor sources by default on dist tarballs)
- rust-lang#133946 (coverage: Prefer to visit nodes whose predecessors have been visited)
- rust-lang#134010 (fix ICE on type error in promoted)
- rust-lang#134029 (coverage: Use a query to find counters/expressions that must be zero)
- rust-lang#134071 (Configure renovatebot)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#134010 - RalfJung:promoted-type-error-ice, r=oli-obk
fix ICE on type error in promoted
Fixes rust-lang#133968
Ensure that when we turn a type error into a "this promoted failed to evaluate" error, we do record this as something that may happen even in "infallible" promoteds.
flip1995 pushed a commit to flip1995/rust that referenced this pull request
…r=oli-obk
fix ICE on type error in promoted
Fixes rust-lang#133968
Ensure that when we turn a type error into a "this promoted failed to evaluate" error, we do record this as something that may happen even in "infallible" promoteds.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.