Advent of tests/ui (misc cleanups and improvements) [2/N] by jieyouxu · Pull Request #134024 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits10 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Part of #133895.
Misc improvements to some ui tests immediately under tests/ui/.
Best reviewed commit-by-commit. Please see individual commit messages for some further rationale and change summaries.
r? compiler
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
- Document the test intention, including both the language semantics it is checking, as well as the borrowck diagnostics that this is exercising.
- Tag this test with
//@ run-rustfixas this ui test exercises a suggestion diagnostics to make an immutable local var mutable. - Minor error annotation reformatting.
This is where assoc-oddities-{1,2}.rs are located, reunite them!
- Include the original MCVE as reported in <rust-lang#28777>.
- Document the intention of the test.
This test exercises the combined effect of the
cfg(target_has_atomic_equal_alignment = "...") implementation in the
compiler as well as the usage of said
cfg(target_has_atomic_equal_alignment) in core.
- Introduce two revisions: one for 32-bit x86 vs one for 64-bit x86_64 and compare & contrast the errors.
- Document the test intention and note its limitations.
Daily ui test suite cleanups and improvements [2/N] Advent of tests/ui (misc cleanups and improvements) [2/N]
Damn, this is high-quality.
@bors r+ rollup
📌 Commit 754dec3 has been approved by Nadrieril
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#133424 (Parse guard patterns)
- rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
- rust-lang#133993 (Fix: typo in E0751 error explanation)
- rust-lang#134013 (Adds new intrinsic declaration)
- rust-lang#134020 (Remove unnecessary
int_type_width_signedfunction) - rust-lang#134024 (Advent of
tests/ui(misc cleanups and improvements) [2/N]) - rust-lang#134038 (deps: Update psm)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#133424 (Parse guard patterns)
- rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
- rust-lang#133993 (Fix: typo in E0751 error explanation)
- rust-lang#134013 (Adds new intrinsic declaration)
- rust-lang#134020 (Remove unnecessary
int_type_width_signedfunction) - rust-lang#134024 (Advent of
tests/ui(misc cleanups and improvements) [2/N]) - rust-lang#134038 (deps: Update psm)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#134024 - jieyouxu:ui-cleanup-2, r=Nadrieril
Advent of tests/ui (misc cleanups and improvements) [2/N]
Part of rust-lang#133895.
Misc improvements to some ui tests immediately under tests/ui/.
Best reviewed commit-by-commit. Please see individual commit messages for some further rationale and change summaries.
r? compiler
Labels
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.