CI: use free runners for x86_64-gnu-llvm jobs by marcoieni · Pull Request #134124 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation94 Commits21 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Split the x86_64-gnu-llvm jobs in two to move them to free runners and reduce the use of large runners in CI.
r? @Kobzol
try-job: x86_64-gnu-llvm-19-1
try-job: x86_64-gnu-llvm-19-2
try-job: x86_64-gnu-llvm-19-3
try-job: x86_64-gnu-llvm-18-1
try-job: x86_64-gnu-llvm-18-2
try-job: x86_64-gnu-llvm-18-3
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2
☀️ Try build successful - checks-actions
Build commit: 3a90623 (3a906231e57c11e9af1a025356a4d7d7acff0fd7)
bors added a commit to rust-lang-ci/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2
☀️ Try build successful - checks-actions
Build commit: 786e8ac (786e8ac3c40d1020fa839ccff8ef4070960ea800)
Too slow. Docker was cached, so that was not it. Probably in this case the build part is slower than the test part? We could use my/your infra analysis scripts to confirm.
we were repeating many thing among the two jobs, I created two script to easily test the job split. Once we are satisfied with this experiment, we can find a more "idiomatic" way to split the tasks among the two jobs 👍
bors added a commit to rust-lang-ci/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2
This comment has been minimized.
This comment has been minimized.
bors added a commit to rust-lang-ci/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3
☀️ Try build successful - checks-actions
Build commit: b9306da (b9306da077ca87a4647b94706d0ef3907619ea0f)
Looks good 👍
| set -ex |
| /tmp/add_dummy_commit.sh |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only be needed for the bootstrap self tests, but the way the skips are configured, these now probably run on both llvm[1/2/3]. Anyway, it doesn't hurt to run it everywhere.
I can't say that I'm happy about this 😆 But it is what it is.
📌 Commit ac078a4 has been approved by Kobzol
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 9 pull requests
Successful merges:
- rust-lang#132056 (Stabilize
#[diagnostic::do_not_recommend]) - rust-lang#134124 (CI: use free runners for x86_64-gnu-llvm jobs)
- rust-lang#134197 (rustc_mir_build: Clarify that 'mirrored' does not mean 'flipped' or 'reversed')
- rust-lang#134260 (Correctly handle comments in attributes in doctests source code)
- rust-lang#134277 (rustdoc-search: handle
impl Into<X>better) - rust-lang#134284 (Keep track of patterns that could have introduced a binding, but didn't)
- rust-lang#134337 (reject unsound toggling of RISCV target features)
- rust-lang#134385 (tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore)
- rust-lang#134386 (Some trait method vs impl method signature difference diagnostic cleanups)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#134124 (CI: use free runners for x86_64-gnu-llvm jobs)
- rust-lang#134197 (rustc_mir_build: Clarify that 'mirrored' does not mean 'flipped' or 'reversed')
- rust-lang#134260 (Correctly handle comments in attributes in doctests source code)
- rust-lang#134277 (rustdoc-search: handle
impl Into<X>better) - rust-lang#134284 (Keep track of patterns that could have introduced a binding, but didn't)
- rust-lang#134337 (reject unsound toggling of RISCV target features)
- rust-lang#134371 (Check for array lengths that aren't actually
usize) - rust-lang#134385 (tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore)
- rust-lang#134386 (Some trait method vs impl method signature difference diagnostic cleanups)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#134124 - MarcoIeni:split-llvm-jobs, r=Kobzol
CI: use free runners for x86_64-gnu-llvm jobs
try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3
For future PRs, it would be nice to clean up the commit history before landing, thanks! 🙏
oh my god, sorry...I forgot 😵
Labels
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the infrastructure team, which will review and decide on the PR/issue.