A bunch of cleanups (part 2) by bjorn3 · Pull Request #134251 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation11 Commits4 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Just like #133567 these were all found while looking at the respective code, but are not blocking any other changes I want to make in the short term.
It is effectively a global resource and the jobserver::Client in Session was a clone of GLOBAL_CLIENT anyway.
rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.
This comment has been minimized.
It only exists to pass some information from one part of the driver to another part. We can directly pass this information to the function that needs it to reduce the amount of mutation of the Session.
This comment has been minimized.
The Miri subtree was changed
cc @rust-lang/miri
📌 Commit 6b595ee has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been minimized.
It is treated as a map already. This is using FxIndexMap rather than UnordMap because the latter doesn't provide an api to pick a single value iff all values are equal, which each_linked_rlib depends on.
📌 Commit 3198496 has been approved by oli-obk
It is now in the queue for this repository.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
A bunch of cleanups (part 2)
Just like rust-lang#133567 these were all found while looking at the respective code, but are not blocking any other changes I want to make in the short term.
This was referenced
Dec 13, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
A bunch of cleanups (part 2)
Just like rust-lang#133567 these were all found while looking at the respective code, but are not blocking any other changes I want to make in the short term.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#134181 (Tweak multispan rendering to reduce output length)
- rust-lang#134209 (validate
--skipand--excludepaths) - rust-lang#134231 (rustdoc-search: fix mismatched path when parent re-exported twice)
- rust-lang#134236 (crashes: more tests v2)
- rust-lang#134240 (Only dist
llvm-objcopyif llvm tools are enabled) - rust-lang#134244 (rustc_borrowck: Stop suggesting the invalid syntax
&mut raw const) - rust-lang#134251 (A bunch of cleanups (part 2))
- rust-lang#134256 (Use a more precise span in placeholder_type_error_diag)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#134251 - bjorn3:various_cleanups2, r=oli-obk
A bunch of cleanups (part 2)
Just like rust-lang#133567 these were all found while looking at the respective code, but are not blocking any other changes I want to make in the short term.
bors pushed a commit to rust-lang-ci/rust that referenced this pull request
A bunch of cleanups (part 2)
Just like rust-lang#133567 these were all found while looking at the respective code, but are not blocking any other changes I want to make in the short term.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.