rust (original) (raw)

My git archeology:

I do not see why the nvptx-types test need cdylib specifically. I checked the original PR NVPTX support for new asm! #72439 and there was no elaboration. To me, this indicates we can change the crate type. If there's some kind of cdylib-specific behavior that this test wanted to check, it's not doing that because the test doesn't seem to be failing here on PR CI.
- cc nvptx64-nvidia-cuda target maintainers @RDambrosio016 and @kjetilkjeka for FYI.
I do not see why the wasm-types test need cdylib specifically. I checked Add wasm32 support to inline asm #78684, no mention of the cdylib crate-type being specifically required. If it was, this test isn't checking that either.
- cc wasm target maintainers (we have a bunch of wasm targets, some Tier 3 some Tier 2) @alexcrichton @hoodmane @juntyr @graydon for FYI.

So, if these two test changes turn out to be undesirable, then we better be documenting the reason for cdylib being load-bearing specifically anyway. Based on the current form of the test themselves, I'm not expecting this to be problematic, but maybe target maintainers know of problems otherwise.

Thanks for the cleanup, this looks good to go for me.
@bors r+ rollup