cleanup promoteds move check by lcnr · Pull Request #134455 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 18, 2024

let promoted_body = &promoted[idx];
// FIXME: This assumes that we don't try to access most fields of the `promoted_mbcx`.
// We may want to move `MoveError` construction and reporting out of `MirBorrowckCtxt`.
let move_data = MoveData::gather_moves(body, tcx, \|_

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be promoted_body?

| let move_data = MoveData::gather_moves(body, tcx, |_| true); | | -------------------------------------------------------------------------- | | let move_data = MoveData::gather_moves(promoted_body, tcx, |_| true); |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, then we probably need a test that actually exercises this, because the fact that this didn't fail makes me very nervous lol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, yeah, that's... interesting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I can tell the answer is: yes, iut should clearly be promoted_body and also: it is entirely unused by check_movable_place which is very gamer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna do the refactor from my fixme i guess, because that's sus

        // FIXME: This assumes that we don't try to access most fields of the `promoted_mbcx`.
        // We may want to move `MoveError` construction and reporting out of `MirBorrowckCtxt`.

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 18, 2024

@rustbot ready

fn report_move_errors does in theory access the move_data field but I don't think it can be triggered rn as the only move error we ever encounter in promoteds are due to array indexing.

Moving this error reporting out of the MirBorrowckCtxt is very painful so I've given up on that approach.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 20, 2024

📌 Commit fc9a14d has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 17, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 17, 2025

…ompiler-errors

cleanup promoteds move check

r? types

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 17, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

rust-lang#134455 (cleanup promoteds move check)
rust-lang#135421 (Make tidy warn on unrecognized directives)
rust-lang#135611 (Remove unnecessary assertion for reference error)
rust-lang#135620 (ci: improve github action name)
rust-lang#135621 (Move some std tests to integration tests)
rust-lang#135639 (new solver: prefer trivial builtin impls)
rust-lang#135654 (add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 18, 2025

…piler-errors

cleanup promoteds move check

r? types

The job x86_64-fuchsia failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

+ .jiri_root/bin/jiri import -name=integration -revision=bb38af4e3d45e490531b71fc52a460003141d032 -overwrite=true flower https://fuchsia.googlesource.com/integration
+ '[' -d .git ']'
+ .jiri_root/bin/jiri update -autoupdate=false
[04:06:41.295] Updating all projects
ERROR: 'git clone --no-checkout --filter=blob:none https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km /checkout/obj/fuchsia/third_party/imgtec-pvr-rgx-km' failed:

stderr:
stderr:
Cloning into '/checkout/obj/fuchsia/third_party/imgtec-pvr-rgx-km'...
fatal: repository 'https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km/' not found
command fail error: exit status 128


[04:08:23.098] Wait for 1m4s before next attempt...: Cloning https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km

[04:09:27.123] Attempt 2/3: Cloning https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km

ERROR: 'git clone --no-checkout --filter=blob:none https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km /checkout/obj/fuchsia/third_party/imgtec-pvr-rgx-km' failed:

stderr:
stderr:
Cloning into '/checkout/obj/fuchsia/third_party/imgtec-pvr-rgx-km'...
fatal: repository 'https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km/' not found
command fail error: exit status 128


[04:09:27.216] Wait for 1m4s before next attempt...: Cloning https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km

[04:10:31.279] Attempt 3/3: Cloning https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km

[04:10:31.373] Jiri packages are not fetched due to fatal errors when updating projects.
[04:10:31.373] Jiri hooks are not run due to fatal errors when updating projects or packages
ERROR: Creating project "third_party/imgtec-pvr-rgx-km": "Cloning https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km" failed 3 times in a row, Last error: 'git clone --no-checkout --filter=blob:none https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km /checkout/obj/fuchsia/third_party/imgtec-pvr-rgx-km' failed:

stderr:
stderr:
Cloning into '/checkout/obj/fuchsia/third_party/imgtec-pvr-rgx-km'...
fatal: repository 'https://fuchsia.googlesource.com/third_party/imgtec-pvr-rgx-km/' not found
command fail error: exit status 128
  local time: Sat Jan 18 04:10:31 UTC 2025
  network time: Sat, 18 Jan 2025 04:10:31 GMT
##[error]Process completed with exit code 1.

bors added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jan 18, 2025

@bors retry

fuchsia not working

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 18, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 18, 2025

…iaskrgr

Rollup of 6 pull requests

Successful merges:

rust-lang#134455 (cleanup promoteds move check)
rust-lang#135421 (Make tidy warn on unrecognized directives)
rust-lang#135611 (Remove unnecessary assertion for reference error)
rust-lang#135620 (ci: improve github action name)
rust-lang#135639 (new solver: prefer trivial builtin impls)
rust-lang#135654 (add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 18, 2025

Rollup merge of rust-lang#134455 - lcnr:move-errors-in-promoteds, r=compiler-errors

cleanup promoteds move check

r? types

lcnr deleted the move-errors-in-promoteds branch

January 20, 2025 09:38

lcnr restored the move-errors-in-promoteds branch

January 30, 2025 15:59

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.