Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver by compiler-errors · Pull Request #134746 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
| let err = first_error.expect("coerce_borrowed_pointer had no error"); |
|---|
| debug!("coerce_borrowed_pointer: failed with err = {:?}", err); |
| return Err(err); |
| if let Some(first_error) = first_error { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unwrap fails b/c above we simply do not see any types to autoderef, since structurally resolving the first autoderef of &<not wf alias> simply fails.
| debug!("coerce_borrowed_pointer: failed with err = {:?}", first_error); |
|---|
| return Err(first_error); |
| } else { |
| // :( |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls explain when this happens, after that r=me
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
📌 Commit 72fa874 has been approved by lcnr
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…-wf-coerce-ice, r=lcnr
Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver
r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#131282 (std: detect stack overflows in TLS destructors on UNIX)
- rust-lang#134746 (Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver)
- rust-lang#135790 (Update windows-gnu targets to set
DebuginfoKind::DWARF) - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
- rust-lang#135879 (fix outdated file path ref in llvm)
- rust-lang#135883 (Remove erroneous
unsafeinBTreeSet::upper_bound_mut) - rust-lang#135884 (remove implied end of slice)
- rust-lang#135898 (rustdoc-json-types: Finalize dyn compatibility renaming)
r? @ghost
@rustbot modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request
…-wf-coerce-ice, r=lcnr
Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver
r? lcnr
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…-wf-coerce-ice, r=lcnr
Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver
r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- rust-lang#134746 (Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver)
- rust-lang#135552 ([AIX] Lint on structs that have a different alignment in AIX's C ABI)
- rust-lang#135764 (Fix tests on LLVM 20)
- rust-lang#135779 (CI: free disk on linux arm runner)
- rust-lang#135790 (Update windows-gnu targets to set
DebuginfoKind::DWARF) - rust-lang#135879 (fix outdated file path ref in llvm)
- rust-lang#135883 (Remove erroneous
unsafeinBTreeSet::upper_bound_mut) - rust-lang#135884 (remove implied end of slice)
- rust-lang#135887 (improvements on
build_steps::testimplementation) - rust-lang#135898 (rustdoc-json-types: Finalize dyn compatibility renaming)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#134746 (Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver)
- rust-lang#135552 ([AIX] Lint on structs that have a different alignment in AIX's C ABI)
- rust-lang#135779 (CI: free disk on linux arm runner)
- rust-lang#135790 (Update windows-gnu targets to set
DebuginfoKind::DWARF) - rust-lang#135879 (fix outdated file path ref in llvm)
- rust-lang#135883 (Remove erroneous
unsafeinBTreeSet::upper_bound_mut) - rust-lang#135884 (remove implied end of slice)
- rust-lang#135887 (improvements on
build_steps::testimplementation) - rust-lang#135898 (rustdoc-json-types: Finalize dyn compatibility renaming)
r? @ghost
@rustbot modify labels: rollup
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
The Rustc Trait System Refactor Initiative (-Znext-solver)